Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasMatchingScope should not allocate a new delegate on every call #7438

Closed
sharwell opened this issue Jun 14, 2023 · 1 comment · Fixed by #7445
Closed

HasMatchingScope should not allocate a new delegate on every call #7438

sharwell opened this issue Jun 14, 2023 · 1 comment · Fixed by #7445
Assignees
@pavel-mikula-sonarsource
Labels
Type: Performance It takes too long.
Milestone
9.4

Comments

@sharwell
Copy link

sharwell commented Jun 14, 2023 •
edited
Loading

Found during review of https://developercommunity.visualstudio.com/t/Visual-Studio-2022:-High-CPU-usage-by-Se/10378039. Accounts for 213MB allocations.

sonar-dotnet/analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs

Line 109 in ab9c515

descriptors.Any(HasMatchingScope);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-mikula-sonarsource pavel-mikula-sonarsource

Labels
Type: Performance It takes too long.
Projects
None yet
Milestone
9.4
Development

Successfully merging a pull request may close this issue.

HasMatchingScope should not allocate a new delegate on every call SonarSource/sonar-dotnet
3 participants
@sharwell @costin-zaharia-sonarsource @pavel-mikula-sonarsource