Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UtilityAnalyzer: Make UtilityAnalyzerBase stateless by removing properties #7288

Closed
mary-georgiou-sonarsource opened this issue May 26, 2023 · 0 comments · Fixed by #8221
Closed

UtilityAnalyzer: Make UtilityAnalyzerBase stateless by removing properties #7288

mary-georgiou-sonarsource opened this issue May 26, 2023 · 0 comments · Fixed by #8221
Assignees
@martin-strecker-sonarsource
Labels
Sprint: Hardening Fix FPs/FNs/improvements Type: Performance It takes too long.

Comments

@mary-georgiou-sonarsource
Copy link
Contributor

Analyzers should be stateless (this helps with thread contention and other potential concurrency issues).

In order for the UtilityAnalyzerBase to be stateless the properties (line 33 - 39) should be removed from this class and injected via a read-only structure.

See here an implementation of this idea.
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title Make UtilityAnalyzerBase stateless by removing properties UtilityAnalyzer: Make UtilityAnalyzerBase stateless by removing properties Jun 12, 2023
Closed
This was referenced Jul 3, 2023
Closed
Closed
@costin-zaharia-sonarsource costin-zaharia-sonarsource added the Sprint: Hardening Fix FPs/FNs/improvements label Oct 18, 2023
This was referenced Oct 18, 2023
Closed
Merged
@sebastien-marichal sebastien-marichal added this to the 9.13 milestone Oct 30, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource removed this from the 9.13 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Sprint: Hardening Fix FPs/FNs/improvements Type: Performance It takes too long.
Projects
None yet
Milestone
No milestone
5 participants
@costin-zaharia-sonarsource @pavel-mikula-sonarsource @mary-georgiou-sonarsource @martin-strecker-sonarsource @sebastien-marichal