Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule S1444: "public static" fields should be also readonly (won't be implemented) #6707

Closed
zsolt-kolbay-sonarsource opened this issue Feb 2, 2023 · 2 comments
Closed

New Rule S1444: "public static" fields should be also readonly (won't be implemented) #6707

zsolt-kolbay-sonarsource opened this issue Feb 2, 2023 · 2 comments
Assignees
@mary-georgiou-sonarsource
Labels
Area: C# C# rules related issues.

Comments

@zsolt-kolbay-sonarsource
Copy link
Contributor

Implement S1444 for C#
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource added this to the 8.53 milestone Feb 8, 2023
@pavel-mikula-sonarsource
Copy link
Contributor

This needs to be considered in relation with S2339 and decision needs to be taken about "Sonar Way", as those rules are contradictory and each makes sense for different projects (exe, web vs. dll)

None of them should probably be in SonarWay

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title New Rule S1444: "public static" fields should be constant New Rule S1444: "public static" fields should be also readonly Feb 15, 2023
@mary-georgiou-sonarsource
Copy link
Contributor

mary-georgiou-sonarsource commented Feb 16, 2023 •
edited
Loading

This rule is already covered by S2223.
The plan is to update the S1444 RSPEC with this information and close this ticket.

PS: There will be a small hardening and description update for S2223 (related PR).

Rspec PR for rule S1444

@mary-georgiou-sonarsource mary-georgiou-sonarsource removed this from the 8.53 milestone Feb 16, 2023
@andrei-epure-sonarsource andrei-epure-sonarsource added this to the 8.54 milestone Feb 17, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title New Rule S1444: "public static" fields should be also readonly New Rule S1444: "public static" fields should be also readonly (won't be implemented) Feb 21, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource removed this from the 8.54 milestone Feb 24, 2023
@Tim-Pohlmann Tim-Pohlmann modified the milestone: 8.54 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
Area: C# C# rules related issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Tim-Pohlmann @andrei-epure-sonarsource @pavel-mikula-sonarsource @mary-georgiou-sonarsource @zsolt-kolbay-sonarsource