Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S1168 FN: Support mathematical operators in generic types #6393

Closed
cristian-ambrosini-sonarsource opened this issue Nov 21, 2022 · 0 comments · Fixed by #6457
Closed
Assignees
Labels
Type: False Negative Rule is NOT triggered when it should be.
Milestone

Comments

@cristian-ambrosini-sonarsource
Copy link
Contributor

Description

FN for S1168 (ReturnEmptyCollectionInsteadOfNull).

Using C#11 static mathematical operator overload, the rule is not raising an issue.

Repro steps

class IInterface : IAdditionOperators<IInterface, IInterface, IEnumerable<string>>
{
    public static IEnumerable<string> operator +(IInterface left, IInterface right) => null; // FN
}

Expected behavior

The rule should raise an issue.

Actual behavior

The rule does not raise an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: False Negative Rule is NOT triggered when it should be.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants