Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S2934 FN: Support unsigned right shift operator (>>>) #6296

Closed
gregory-paidis-sonarsource opened this issue Nov 7, 2022 · 0 comments · Fixed by #6363
Closed

Fix S2934 FN: Support unsigned right shift operator (>>>) #6296

gregory-paidis-sonarsource opened this issue Nov 7, 2022 · 0 comments · Fixed by #6363
Assignees
Labels
Type: False Negative Rule is NOT triggered when it should be.
Milestone

Comments

@gregory-paidis-sonarsource
Copy link
Contributor

Description

FN for S2934 (GenericReadonlyFieldPropertyAssignment).

Using C#11 unsigned right shift operator (>>>), the rule is not raising an issue.

Repro steps

 interface IPoint
    {
        int X { get; set; }
        int Y { get; set; }
    }

    class PointManager<T> where T : IPoint
    {
        readonly T point;  // this could be a struct

        public void MovePointVertically(int newX)
        {
            point.X >>>= 4; // FN
        }
    }

Expected behavior

The rule should raise an issue.

Actual behavior

The rule does not raise an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: False Negative Rule is NOT triggered when it should be.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants