Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FP S5332: Improve detection of namespace uris #6223

Closed
12 tasks done
martin-strecker-sonarsource opened this issue Oct 18, 2022 · 2 comments · Fixed by #7482
Closed
12 tasks done

FP S5332: Improve detection of namespace uris #6223

martin-strecker-sonarsource opened this issue Oct 18, 2022 · 2 comments · Fixed by #7482
Assignees
@martin-strecker-sonarsource
Labels
Area: C# C# rules related issues. Area: Security Related to Vulnerability and Security Hotspot rules Area: VB.NET VB.NET rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
9.5

Comments

@martin-strecker-sonarsource
Copy link
Contributor

martin-strecker-sonarsource commented Oct 18, 2022 •
edited
Loading

Uris used for namespaces start with http and are not reported by S5332. The detection of namespace uris can be improved:

Copied from
#6141 (comment)

Update list of well-known namespaces
@martin-strecker-sonarsource martin-strecker-sonarsource added Type: False Positive Rule IS triggered when it shouldn't be. Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. Area: Security Related to Vulnerability and Security Hotspot rules labels Oct 18, 2022
Closed
@rjgotten
Copy link

FWIW, the check list does not yet reference XNamespace, which is also affected by the false positive.

And your list of well-known namespaces could also have sitemaps added:
http://www.sitemaps.org/schemas/sitemap/0.9

@martin-strecker-sonarsource martin-strecker-sonarsource added this to the 9.5 milestone Jun 20, 2023
Merged
@martin-strecker-sonarsource
Copy link
Contributor Author

Thank you @rjgotten for reporting. The sitemap namespace will be added. Support for the XNamespace API will also be added, but with some limitations. See the test case for details:
https://github.com/SonarSource/sonar-dotnet/pull/7482/files#diff-9d22fd8dc259a8a9bcc0bacccf088e947ebd6f9f1d01a2a327c9f7c53031cfcbR362-R369

Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: C# C# rules related issues. Area: Security Related to Vulnerability and Security Hotspot rules Area: VB.NET VB.NET rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
9.5
Development

Successfully merging a pull request may close this issue.

FP S5332: Improve detection of namespace uris SonarSource/sonar-dotnet
4 participants
@rjgotten @Tim-Pohlmann @pavel-mikula-sonarsource @martin-strecker-sonarsource