Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S1313: Exclude reserved documentation IP ranges #6064

Closed
hendrik-buchwald-sonarsource opened this issue Sep 6, 2022 · 0 comments · Fixed by #6165
Closed

Rule S1313: Exclude reserved documentation IP ranges #6064

hendrik-buchwald-sonarsource opened this issue Sep 6, 2022 · 0 comments · Fixed by #6165
Assignees
@martin-strecker-sonarsource
Labels
Area: C# C# rules related issues. Area: Security Related to Vulnerability and Security Hotspot rules Area: VB.NET VB.NET rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
8.47

Comments

@hendrik-buchwald-sonarsource
Copy link

S1313 should not report an issue for the following IP ranges:

  • 192.0.2.0/24
  • 198.51.100.0/24
  • 203.0.113.0/24
  • 2001:db8::/32

In other words, no issue should be reported if the IP address starts with:

  • 192.0.2.
  • 198.51.100.
  • 203.0.113.
  • 2001:db8:

The ranges are reserved for documentation purposes by RFC 5737 and RFC 3849.

After implementing this ticket please merge SonarSource/rspec#1222.
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource added Type: False Negative Rule is NOT triggered when it should be. Area: Security Related to Vulnerability and Security Hotspot rules labels Sep 6, 2022
Merged
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource added Type: False Positive Rule IS triggered when it shouldn't be. and removed Type: False Negative Rule is NOT triggered when it should be. labels Sep 6, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource added Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. labels Sep 6, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 8.47 milestone Oct 3, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: C# C# rules related issues. Area: Security Related to Vulnerability and Security Hotspot rules Area: VB.NET VB.NET rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
8.47
Development

Successfully merging a pull request may close this issue.

Rule S1313: Exclude reserved documentation IP ranges SonarSource/sonar-dotnet
3 participants
@pavel-mikula-sonarsource @hendrik-buchwald-sonarsource @martin-strecker-sonarsource