Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LVA in the new SE #5459

Closed
pavel-mikula-sonarsource opened this issue Mar 7, 2022 · 0 comments · Fixed by #5475
Closed

Use LVA in the new SE #5459

pavel-mikula-sonarsource opened this issue Mar 7, 2022 · 0 comments · Fixed by #5475
Assignees
Labels
Area: CFG/SE CFG and SE related issues.
Milestone

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Mar 7, 2022

Use RoslynLiveVariableAnalysis in RoslynSymbolicExecution. It should be used the same way as the old LVA in the old SE.

In best-case scenario, create the instance inside the RoslynSymbolicExecution constructor.

Consider if we can remove originalDeclaration from the LVA constructor as it's only used to detect IsLocal. That should be inferrable from the CFG.

We also need a mechanism to prevent symbols to be released by LVA. Because we need to track their state as it is the case for S2222. We need to update this rule to use the API to preserve symbol tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CFG/SE CFG and SE related issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants