Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule S110: should support concurrent execution #4745

Closed
dmitry-golovinov-sonarsource opened this issue Jul 30, 2021 · 1 comment · Fixed by #5530
Closed

Rule S110: should support concurrent execution #4745

dmitry-golovinov-sonarsource opened this issue Jul 30, 2021 · 1 comment · Fixed by #5530
Assignees
Labels
Area: C# C# rules related issues. Type: Performance It takes too long.
Milestone

Comments

@dmitry-golovinov-sonarsource
Copy link
Contributor

dmitry-golovinov-sonarsource commented Jul 30, 2021

Description

When launching test AvoidExcessiveInheritance_DefaultValues with concurrent execution on, we've got the issue, that Other_6 class (line 61) has 13 parents instead of 6 expected. This is obviously not correct and needs to be investigated and fixed. After that, concurrent execution could be enabled for that rule.

Expected behavior

AvoidExcessiveInheritance_DefaultValues test should pass in concurrent mode.

Related information

  • C#/VB.NET Plugins version 8.27
@pavel-mikula-sonarsource
Copy link
Contributor

To reproduce the issue, the whole file is currently wrapped in a namespace for concurrency. So the problem is related to double-nested namespaces.

UT should be added to _DefaultCases.cs.

This mign not be related to concurrency, but can be just a FP in that double-nested case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C# C# rules related issues. Type: Performance It takes too long.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants