-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S3925 FP: Classes not having extra properties should not have to extend ISerializable interface #3945
Comments
According to the RSpec, this is indeed a false positive:
|
@Corniel This issue was closed as part of our work at #7721. This issue is slightly different, but I don't think it is needed anymore as it should cover the changes we made. If you still think that there are FPs, feel free to re-open or raise a new issue. |
I think this solution should also work. |
Description
Rule S3925 demands that classes should always override
ISerializable
methods. However, if the class has no extra properties (or fields) this is not necessary, like in this scenario:The rule should not be applied in cases like these.
The text was updated successfully, but these errors were encountered: