Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S4830: add a message on secondary locations #3682

Closed
nicolas-harraudeau-sonarsource opened this issue Oct 27, 2020 · 1 comment · Fixed by #8226
Closed

Update S4830: add a message on secondary locations #3682

nicolas-harraudeau-sonarsource opened this issue Oct 27, 2020 · 1 comment · Fixed by #8226
Assignees
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Sprint: Hardening Fix FPs/FNs/improvements
Milestone

Comments

@nicolas-harraudeau-sonarsource
Copy link

nicolas-harraudeau-sonarsource commented Oct 27, 2020

RSPEC-4830 creates a secondary location on functions' return value. This location can be quite far from the primary location and developers will expect to navigate to it in SonarLint. Thus we need to add a message to this secondary location.

@eric-therond-sonarsource any idea for the message? I would suggest "This function trusts all certificates."
Screenshot 2020-10-27 at 17 02 02

The secondary location message is written in the RSPEC.

@nicolas-harraudeau-sonarsource nicolas-harraudeau-sonarsource added Type: Improvement Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. labels Oct 27, 2020
@eric-therond-sonarsource

@nicolas-harraudeau-sonarsource your suggestion "This function trusts all certificates." seems really good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Sprint: Hardening Fix FPs/FNs/improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants