Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin should support C# and VB.NET pointing to the same coverage report #2025

Closed
Evangelink opened this issue Oct 26, 2018 · 0 comments
Closed

Plugin should support C# and VB.NET pointing to the same coverage report #2025

Evangelink opened this issue Oct 26, 2018 · 0 comments
Assignees
@Evangelink
Labels
Area: C# C# rules related issues. Area: SQ Plugin Java plugin related issues. Area: VB.NET VB.NET rules related issues. Type: Bug Exceptions and blocking issues during analysis.
Milestone
7.10

Comments

@Evangelink
Copy link
Contributor

Description

A solution mixing both C# and VB.NET, using a single coverage report and providing the same report for the 2 languages (at the scanner level) will result in a failing analysis.

TODO

  1. Check if the problem happens only for MSTest/VSTest coverage reports
  2. Decide how we want to solve/handle this problem
    • 1 solution is to stop relying on .cs. and .vbnet. specifiers to move to something like .dotnet. as the different languages are considered as one for the coverage tool.
    • Another solution is to filter out the files on which we apply coverage by extension (matching the SQ configuration)
@Evangelink Evangelink added Type: Bug Exceptions and blocking issues during analysis. Area: SQ Plugin Java plugin related issues. Area: VB.NET VB.NET rules related issues. Status: Confirmed Area: C# C# rules related issues. labels Oct 26, 2018
@Evangelink Evangelink modified the milestone: 7.10 Dec 7, 2018
@Evangelink Evangelink self-assigned this Dec 14, 2018
@Evangelink Evangelink added this to the 7.10 milestone Dec 17, 2018
@Evangelink Evangelink changed the title Code coverage for a solution with C# and VB. NET fails Plugin should support C# and VB.NET pointing to the same coverage report Dec 17, 2018
@Evangelink Evangelink mentioned this issue Dec 17, 2018
Merged
@ghost ghost removed the Status: Needs Review label Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
Area: C# C# rules related issues. Area: SQ Plugin Java plugin related issues. Area: VB.NET VB.NET rules related issues. Type: Bug Exceptions and blocking issues during analysis.
Projects
None yet
Milestone
7.10
Development

No branches or pull requests
1 participant
@Evangelink