Fix S3242: Rule should not throw ArgumentException

[antrv]

No code sample for reproducing this bug yet (I cannot provide original code).

[antrv]

I could not catch the descriptive message again, so I attached the screenshot.

[Evangelink]

Hi @antrv,
I was reviewing the code and just saw we build a dictionary with the name of parameters as key (which seems to match your exception). Could you confirm you have any method with multiple parameters with the same name? I will try to make some tests later on but for now we have a lot of things to deal with on SonarLint for VS.

[antrv]

yes, I have many methods with the same parameter names, only type parameters differ.
for example:
Method<T1, T2>(Tuple<T1, T2> tuple, Action<Tuple<T1, T2>> action)
Method<T1, T2, T3>(Tuple<T1, T2, T3> tuple, Action<Tuple<T1, T2, T3>> action)

[antrv]

and even (simplified)
Method<T1, T2, T3>(Tuple<Tuple< T1 >, Tuple<T2, T3>> tuple, Action<Tuple< T1 >, Tuple<T2, T3>> action)
and
Method<T1, T2, T3>(Tuple<Tuple<T1, T2>, Tuple< T3 >> tuple, Action<Tuple<T1, T2>, Tuple< T3 >> action)

[Evangelink]

Hi @antrv,
Sorry to get back to you so late but the only case where I can reproduce the error is actually when I create a method that doesn't compile with 2 or more parameters with the same name. For example:

private void Foo(IList<int> a, IList<string> a)
{
    a.ToList();
}

Does it match your use case or do you think you are having a different bug?

[antrv]

Hi @Evangelink ,
I think I have a different bug. My code compiles.
Please keep this bug open for a week or two. I will try to provide code sample for it.
Thank you

[Evangelink]

Will do :)

[Evangelink]

Hi @antrv,

We have received a similar bug through the SonarLint Google Group:

Both screenshots show an error on the ToDictionary call.

[Evangelink]

Fixed by PR #835