Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S4261: False positive on async Main #1644

Closed
jincod opened this issue Aug 9, 2018 · 1 comment
Closed

Fix S4261: False positive on async Main #1644

jincod opened this issue Aug 9, 2018 · 1 comment
Assignees
@Evangelink
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
7.4

Comments

@jincod
Copy link

jincod commented Aug 9, 2018

Description

A false positive S4261 is thrown on the line:

Repro steps

static async Task Main(string[] args)

Expected behavior

Don't suggest to rename method Main

Actual behavior

image

Related information

  • SonarC# Version 7.3 (build 5690)
  • SonarScanner for MSBuild 4.1.1.1164 - .NET Fwk 4.6 (Jenkins plugin)
@Evangelink Evangelink self-assigned this Aug 9, 2018
@Evangelink Evangelink added Status: In Progress Type: False Positive Rule IS triggered when it shouldn't be. labels Aug 9, 2018
@Evangelink Evangelink added this to the 7.4 milestone Aug 9, 2018
@Evangelink Evangelink changed the title S4261: False positive on async Main Fix S4261: False positive on async Main Aug 9, 2018
@Evangelink
Copy link
Contributor

Hi @jincod,

Thanks for the feedback! We will fix this FP in the current sprint.

Cheers,
Amaury

@Evangelink Evangelink mentioned this issue Aug 9, 2018
Merged
@ghost ghost removed the Status: Needs Review label Aug 9, 2018
@valhristov valhristov mentioned this issue Aug 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
7.4
Development

No branches or pull requests
2 participants
@jincod @Evangelink