Fix S1450: Rule should not raise an issue when methods call each other

[fmallet]

using System;
class C
{
    private bool f; // Compliant

    public void M1()
    {
        f = true;
        M2(); // M2 modifies "f" and the field cannot be removed
        Console.Write(f);
    }

    public void M2()
    {
        f = false;
    }
}

See RSPEC-1450 and SONARCS-676

[p3root]

I have the following situation where SonarQube puts out a warning!

public class Foo {
   private readonly int moo;

  public Foo(int moo) {
      this.moo = moo;
   }

   public too() {
     //do something with this.moo
   }
   public too2() {
     //do something with this.moo
   }
   
}

In think this is an legal case, or am I wrong?

[duncanp-lseg]

@p3root Apologies the huge delay in responding, and thanks for providing a repro.

We've recently had a sweep through some older FP issues to try to resolve them and I've had a quick look at this one. I can't get the issue to repro with the following code based on the example you provided (tweaked slightly so it compiles):

    public class Foo
    {
        private readonly int moo;

        public Foo(int moo)
        {
            this.moo = moo;
        }

        public void too()
        {
            //do something with this.moo
            Console.WriteLine(moo);
        }

        public void too2()
        {
            //do something with this.moo
            Console.WriteLine(moo);
        }
    }

Does the modified code accurately reflect your scenario?

FYI the issue does repro with the m1, m2 code snipped above (again, tweaked so that it compiles).