Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S107: Do not raise for P/Invoke methods (#1459) #1493

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

lukas-ais
Copy link
Contributor

@lukas-ais lukas-ais commented Jun 21, 2018

Fix #1459

@duncanp-lseg duncanp-lseg added this to the 7.3 milestone Jun 22, 2018
@duncanp-lseg duncanp-lseg added Area: Rules Type: False Positive Rule IS triggered when it shouldn't be. labels Jun 22, 2018
Copy link
Contributor

@duncanp-lseg duncanp-lseg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duncanp-lseg
Copy link
Contributor

Thanks @lukas-ais!

FYI this fix will ship in the next release of the analyzer, which we're aiming to do next week or the first week in July.

@duncanp-lseg duncanp-lseg merged commit 1a603e8 into SonarSource:master Jun 22, 2018
@lukas-ais
Copy link
Contributor Author

Hi @duncanp-sonar

I was wondering why the CI build was not started/completed for about 24 hours. Is this normal? Do I have to do anything else to get the build running?

Do we need any changes on the any other part of SonarQube? According to the contributors document there is a difference between "plugin" and "analyzer".

@valhristov
Copy link
Contributor

The CI works only for PRs initiated from the sonar-csharp repository. Otherwise someone could commit script that does bad things to the build machines (formats hard drive, downloads viruses, etc.) that will be automatically executed when a PR is opened.

@duncanp-lseg
Copy link
Contributor

@lukas-ais The "plugin" is the Java part of the handles the interaction with SonarQube.
The rules are completely in the C# analyzer part, so since you just changed a rule then there is nothing else to do.

@lukas-ais lukas-ais deleted the FixS107forPInvoke branch June 25, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants