Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update S4457: make message clearer #1387

Closed
valhristov opened this issue May 8, 2018 · 2 comments · Fixed by #1395
Closed

Update S4457: make message clearer #1387

valhristov opened this issue May 8, 2018 · 2 comments · Fixed by #1395
Assignees
@Evangelink
Milestone
7.2

Comments

@valhristov
Copy link
Contributor

Currently the rule reports with the following message: Split this method into two, one handling parameters check and the other handling the iterator.. The word iterator should be replaced so that it is not confusing what the rule is about.
@valhristov valhristov added Type: Bug Exceptions and blocking issues during analysis. Status: Needs Review labels May 8, 2018
@valhristov valhristov added this to the 7.2 milestone May 8, 2018
@valhristov valhristov mentioned this issue May 8, 2018
Closed
@Evangelink
Copy link
Contributor

@valhristov What's your suggestion? This is actually the wording that was used by MS in the article were we found the rule idea.

@Evangelink Evangelink added Type: Improvement and removed Status: Needs Review Type: Bug Exceptions and blocking issues during analysis. labels May 10, 2018
@valhristov
Copy link
Contributor Author

I did not have time to think of better message, but at least it should not mention iterator because the rule is about async methods.

@Evangelink Evangelink changed the title Review the message of S4457 Update S4457: make message clearer May 15, 2018
@Evangelink Evangelink self-assigned this May 15, 2018
@Evangelink Evangelink mentioned this issue May 15, 2018
Merged
@valhristov valhristov mentioned this issue Jun 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
None yet
Projects
None yet
Milestone
7.2
Development

Successfully merging a pull request may close this issue.

Improve S4456 and S4457 detection SonarSource/sonar-dotnet
2 participants
@Evangelink @valhristov