Multiple minor clean ups. #151

Author: meri

src/main/java/com/github/sommeri/less4j/core/ast/NumberExpression.java

@@ -5,7 +5,6 @@
 import java.util.List;
 import java.util.Map;
 
-import com.github.sommeri.less4j.core.ast.NumberExpression.Dimension;
 import com.github.sommeri.less4j.core.ast.annotations.NotAstProperty;
 import com.github.sommeri.less4j.core.parser.HiddenTokenAwareTree;
 

src/main/java/com/github/sommeri/less4j/core/compiler/selectors/SelectorsComparatorForExtend.java

@@ -54,7 +54,6 @@ private boolean containsInList(List<SelectorPart> lookForParts, List<SelectorPar
     return contains;
   }
 
-  //FIXME: (!!!) test with combinator before and in the end
   private Selector replaceInList(List<SelectorPart> lookForParts, Selector inSelector, List<SelectorPart> originalReplaceBy) {
     List<SelectorPart> inSelectorParts = inSelector.getParts();
     SelectorPartsListBuilder builder = new SelectorPartsListBuilder();

src/main/java/com/github/sommeri/less4j/core/compiler/selectors/SimpleSelectorComparator.java

@@ -12,7 +12,6 @@
 import com.github.sommeri.less4j.utils.ListsComparator.ListMemberComparator;
 import com.github.sommeri.less4j.utils.ListsComparator.MatchMarker;
 
-//FIXME: (!!!!) this whole class mostly ignores leading combinators - need special logic for them
 public class SimpleSelectorComparator implements ListMemberComparator<SimpleSelector> {
 
   private final SelectorsComparatorUtils utils;
@@ -156,7 +155,7 @@ private boolean simpleSelectorsElementsEqual(SimpleSelector first, SimpleSelecto
   }
 
   private boolean combinatorsEqual(SelectorCombinator cmb1, SelectorCombinator cmb2) {
-    //FIXME: (!!!) this is here to solve special case, leading combinators must be rethingg
+    //FIXME: this is here to solve special case, leading combinators must be re-thinked
     // the problem is that 
     /* 
      * h1 {} has empty leading combinator
@@ -184,7 +183,6 @@ public boolean contains(SimpleSelector lookFor, SimpleSelector inside) {
   public SimpleSelector[] splitOn(SimpleSelector lookFor, SimpleSelector inside) {
     if (hasNoElement(lookFor)) {
       //FIXME: (!!!!) test na tento flow!!!
-      //FIXME: (!!!!) move to list comparator -what did I meant by that?
       List<ElementSubsequent> subsequents = inside.getSubsequent();
       HiddenTokenAwareTree underlying = inside.getUnderlyingStructure();
 

src/main/java/com/github/sommeri/less4j/core/parser/ASTBuilderSwitch.java

@@ -63,7 +63,6 @@
 import com.github.sommeri.less4j.core.ast.RuleSet;
 import com.github.sommeri.less4j.core.ast.Selector;
 import com.github.sommeri.less4j.core.ast.SelectorAttribute;
-import com.github.sommeri.less4j.core.ast.SelectorCombinator.Combinator;
 import com.github.sommeri.less4j.core.ast.SelectorOperator;
 import com.github.sommeri.less4j.core.ast.SelectorPart;
 import com.github.sommeri.less4j.core.ast.SignedExpression;

src/main/java/com/github/sommeri/less4j/utils/ArraysUtils.java

@@ -45,7 +45,7 @@ public static <T> List<T> sublistWithoutFirst(List<T> values) {
 
   public static <T> List<T> safeSublist(List<T> values, int from, int to) {
     if (values.isEmpty())
-      return null; //FIXME: (!!) change to return empty? or remove?
+      return null; 
 
     if (from>to)
       return new ArrayList<T>();

src/main/java/com/github/sommeri/less4j/utils/ListsComparator.java

@@ -132,14 +132,6 @@ public <T> List<MatchMarker<T>> collectMatches(List<T> lookFor, List<T> inList,
     return result;
   }
 
-  private <T> boolean containsInList(T lookFor, List<T> inParts, ListMemberComparator<T> comparator) {
-    for (T inPart : inParts) {
-      if (comparator.contains(lookFor, inPart))
-        return true;
-    }
-    return false;
-  }
-
   private <T> List<MatchMarker<T>> collectMatches(T lookFor, List<T> inParts, ListMemberComparator<T> comparator, List<MatchMarker<T>> result) {
     for (T inPart : inParts) {
       if (comparator.contains(lookFor, inPart))