Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AWS KMS #60

Closed
omerlh opened this issue Dec 31, 2018 · 2 comments
Closed

Add support for AWS KMS #60

omerlh opened this issue Dec 31, 2018 · 2 comments
Assignees
@shaikatz
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@omerlh
Copy link
Contributor

omerlh commented Dec 31, 2018

To support kubernetes cluster running on AWS. Look like there is support for it in the dotnet SDK.
Open questions:

  • Is KMS the right choice here? Maybe HSM is a better choice?
  • How do we handle authentication to KMS/HSM? Pod IAM?
@omerlh omerlh added enhancement New feature or request help wanted Extra attention is needed labels Dec 31, 2018
@omerlh omerlh pinned this issue Feb 25, 2019
@shaikatz shaikatz self-assigned this Mar 3, 2019
@max-lobur
Copy link

I made a note regarding auth: #120 (comment)
tl;dr don't. Just let AWS SDK figure out.
And use https://github.com/uswitch/kiam, or extend k8s node roles.

@shaikatz shaikatz mentioned this issue Mar 7, 2019
Merged
@shaikatz
Copy link
Contributor

shaikatz commented Mar 7, 2019

Done!

@shaikatz shaikatz closed this as completed Mar 7, 2019
@shaikatz shaikatz unpinned this issue Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaikatz shaikatz

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@max-lobur @omerlh @shaikatz