Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smile_elasticsuite_thesaurus_store not updating #674

Closed
mdroidian opened this issue Dec 29, 2017 · 5 comments
Closed

smile_elasticsuite_thesaurus_store not updating #674

mdroidian opened this issue Dec 29, 2017 · 5 comments
Assignees
Labels

Comments

@mdroidian
Copy link

Preconditions

Magento Version : 2.2.2 EE

ElasticSuite Version : 2.4

Environment : Dev

Third party modules :

Steps to reproduce

  1. Add Synonym or Expansion
  2. ElasticSuite Thesaurus Indexing On Save or Schedule

Expected result

  1. smile_elasticsuite_thesaurus_store updates thesaurus_id, store_id
  2. search for sysnonym on storefront

Actual result

  1. smile_elasticsuite_thesaurus_store remains blank

Anyone have this issue? How could we debug it?
If we manually add the thesaurus_id, store_id to smile_elasticsuite_thesaurus_store and reindex ... works as expected.

@mdroidian
Copy link
Author

mdroidian commented Dec 29, 2017

Enable Synonyms Search: Yes
Single Store Mode: On

@mdroidian
Copy link
Author

mdroidian commented Dec 29, 2017

Seems like

  • Single Store Mode: OFF

Works as expected.

@cft-mike
Copy link

Smile\ElasticsuiteThesaurus\Model\ResourceModel\Thesaurus

private function saveStoreRelation(\Magento\Framework\Model\AbstractModel $object)

$storeIds = $object->getStoreIds(); returns an empty array when single store mode is on
Setting the $storeIds[] = 0 when array is empty fixes this index issue.

Not sure if $storesIds is supposed to return a value when on single store mode, and is part of another issue?

@romainruaud
Copy link
Collaborator

Confirmed.

Store relation is not stored properly when using single store mode. Should be defaulted in this case.

I will provide a fix for this one to 2.4.x and master version.

Regards, and thank you for reporting it.

@afoucret
Copy link
Contributor

afoucret commented Jan 3, 2018

PR #676 have been merged in branch 2.4.x.
Will ne part of the next bugfix release.

@afoucret afoucret closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants