Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Virtual Rule attribute to extension_attributes #541

Closed
romainruaud opened this issue Sep 22, 2017 · 1 comment
Closed

Move Virtual Rule attribute to extension_attributes #541

romainruaud opened this issue Sep 22, 2017 · 1 comment

Comments

@romainruaud
Copy link
Collaborator

Hello @afoucret

I am currently wondering about migrating the former "virtual_rule" attributes of the categories to an extension_attribute.

The pros :

  • prevent the backend model of the attribute from being saved in DB : this allow to properly de-activating elasticsuite without having to clean the database manually.

  • imho this is more consistent to the Magento's philosophy : complex objects added to entities is more likely to be done via extension_attributes.

The cons :

  • this would require to store the rules elsewhere than the category eav attribute table : so a migration script (via the Setup of newest version ?) would be mandatory in case of version upgrade

Your opinion ?

@afoucret
Copy link
Contributor

PR #863 have been merged.
Will be part of release 2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants