Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report : Remove display of Facet Attribute when all products have same option. #1078

Closed
Amadeco opened this issue Sep 13, 2018 · 3 comments
Closed
Labels

Comments

@Amadeco
Copy link

Amadeco commented Sep 13, 2018

Preconditions

Magento Version : Magento CE 2.2.5
ElasticSuite Version : 2.6.1
Environment : Developer
Third party modules : Not related to layered navigation and products lists.

Good afternoon,

This is a report about the issue #1042.
The pull request #1051 doesn't seems to solve the problem.

There are still many filters which have only one option :
capture d ecran 2018-09-13 a 17 37 58

Have you tried yourself your new release to know wether it fix this issue or not ?

Ilan

@romainruaud
Copy link
Collaborator

Hello @mageho

Please, don't be so salty when submitting an issue ...

PR #1051 will hide a filter if it has only one value that matches the entire product collection.

As I can see on your screen, the "Avec rallonge : Oui" is matching 5 products among 6 results.

In this case, the filter is relevant and should not be hidden, because if you apply it, it will remove one article from the list.

So imho, your case is invalid. We'll be glad to dig more if you are able to reproduce it on a proper use case (would be correct if "Avec rallonge : Oui" was matching 6 products here).

Regards,

@Amadeco
Copy link
Author

Amadeco commented Sep 14, 2018

Good morning,

You misundertand me, I was not sure if it was the correct behavior of your extension.
As I know, the field yes/no did not show up the filter No option.
Which is defined for the last product of this example list.

I have this situation with complementary module of ElasticSuite, Ratings.
Is this related to the core or to the complementary module ? Or is it the expected behaviour ?

capture d ecran 2018-09-14 a 11 35 46

Thank you,

Ilan

@romainruaud
Copy link
Collaborator

Hello, not a surprise to me that the same issue is still present in the rating module.

This module do have its own Layer/Filter/Attribute implementation and is therefore not targeted by the fix provided in #1051

Please open an issue on this module directly.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants