You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using only the context for shutting down background threads leads to unclean shutdowns. Use specific start/stop methods.
Design or Proposal
Start should create a thread-wide waitgroup and the Stop should wait on it to finish before exiting.
When we Start the service from main, we should also defer Stop().
The text was updated successfully, but these errors were encountered:
Overview
Using only the context for shutting down background threads leads to unclean shutdowns. Use specific start/stop methods.
Design or Proposal
Start
should create a thread-wide waitgroup and theStop
should wait on it to finish before exiting.When we
Start
the service frommain
, we should alsodefer Stop()
.The text was updated successfully, but these errors were encountered: