Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQLDictionaryService should handle null entries #2027

Open
Lemholt opened this issue Feb 4, 2025 · 1 comment
Open

GraphQLDictionaryService should handle null entries #2027

Lemholt opened this issue Feb 4, 2025 · 1 comment
Labels

Comments

@Lemholt
Copy link

Lemholt commented Feb 4, 2025

Describe the Bug

If there are any null entries in a sites dictionary the GraphQLDictionaryService will throw an error. This has happened multiple times and can be a language missing or similar that is halting the entire build.

To Reproduce

Have an empty/null entry in your dictionary.

Expected Behavior

The GraphQLDictionaryService should not break and simply filter these null values out.

Possible Fix

Check for null entries in the result for dictionary services and ignore these.

Provide environment information

  • Sitecore Version: 10.4.1
  • JSS Version: 22.4.1
  • Browser Name and version: ALL
  • Operating System and version (desktop or mobile): ALL
  • Link to your project (if available):
@yavorsk
Copy link
Contributor

yavorsk commented Feb 11, 2025

Hi @Lemholt I tried testing this on a basic site, with two languages and could not reproduce that behavior.
Is there a reproduction step that I might be missing?

@illiakovalenko illiakovalenko added backlog Issue/PR/discussion is reviewed and added to backlog for the further work and removed backlog Issue/PR/discussion is reviewed and added to backlog for the further work labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants