Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not tested on PyPy. With current state of ctypes in PyPy it is unlikely to be worth to support. #38

Open
dgpv opened this issue Jul 13, 2020 · 0 comments

Comments

@dgpv
Copy link

dgpv commented Jul 13, 2020

pypy3 -u -m unittest bitcointx.tests.test_scripteval.Test_EvalScript.test_script_bitcoinconsensus

fails with _ctypes.basics.ArgumentError: Expected bytes of length one as character

while the arguments are clearly multi-byte (but even if it was bytes of length 1, this error should not be raised, in my understanding).

It seems that ctypes is a second-class citizen in PyPy land, and cffi is preferred, while python-bitcointx uses ctypes and there's no point in using more heavy ffi package.

Debugging these quirks is too costly.

Because of this, I removed PyPy from the tests in .travis.yml in 302f4f3, to indicate that python-bitcointx cannot be expected to work correctly with PyPy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant