Modular Computers Part 2: Disk Burner #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sleepyyapril <[email protected]>
Signed-off-by: sleepyyapril <[email protected]>
Co-authored-by: VMSolidus <[email protected]> Signed-off-by: Eris <[email protected]>
github-actions
bot
added
Changes: C#
Signed-off-by: Eris <[email protected]>
Signed-off-by: sleepyyapril <[email protected]>
|
Fix #1584 first :) |
👍 |
Fixed, ready for merge |
|
This too |
I'm like 99% sure that comes from adding ItemSlots component which I don't think I can get around, so... Not My Fault |
How does anything else get around it then, silly? Check guns, for example. It's your code doing something to containers |
|
@sleepyyapril Fixed, both in testfix PR and this one |
Signed-off-by: Eris <[email protected]>
|
I am beginning to lose sanity over the failure of tests. |
|
Can I stop catching EVERY heisentest under the sun man?! |
|
Finally, tests passing |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
are you fucking kidding me |
Signed-off-by: Eris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is Part 2 of the Modular Computers system, adding the functional player facing stuff- the modular computer itself, a way to make and burn disks via the Disk Burner and a related research.
Also comes with some cleanup changes to fix parts of the system that broke in testing.
TODO
Media
NO.
Changelog
🆑