Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salvage Magnet UI and Character Switching Height/Width Bug Fix #1347

Merged
merged 4 commits into from
Dec 14, 2024
Merged

Salvage Magnet UI and Character Switching Height/Width Bug Fix #1347

merged 4 commits into from
Dec 14, 2024

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Dec 14, 2024 •
edited
Loading

Description

i fixed it

also added a button "Connect & Go to Lobby" for people testing lobby stuff!

Resolves #1131

Changelog

🆑

  • fix: Fixed the bug where switching characters made your width/height change to incorrect values.
  • fix: Fixed the salvage magnet opening ten times.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Dec 14, 2024
@sleepyyapril sleepyyapril added Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs labels Dec 14, 2024
@sleepyyapril sleepyyapril requested review from a team, Aidenkrz, FoxxoTrystan, Remuchi, Pspritechologist and OldDanceJacket and removed request for a team December 14, 2024 08:25
@sleepyyapril
Copy link
Contributor Author

it does not fix it.

@sleepyyapril sleepyyapril added the Status: Do Not Merge Do not merge label Dec 14, 2024
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Dec 14, 2024
@sleepyyapril sleepyyapril removed the Status: Do Not Merge Do not merge label Dec 14, 2024
@sleepyyapril
Copy link
Contributor Author

this does though!

@sleepyyapril
Forgot to remove this
8bf73b3 
Signed-off-by: sleepyyapril <[email protected]>
@sleepyyapril sleepyyapril merged commit c4c3e42 into Simple-Station:master Dec 14, 2024
11 of 12 checks passed
@sleepyyapril sleepyyapril deleted the more-fixes-tm branch December 14, 2024 18:09
sleepyyapril pushed a commit to sleepyyapril/Einstein-Engines that referenced this pull request Dec 15, 2024
@SimpleStation14
Automatic Changelog Update (Simple-Station#1347)
8ff7021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@FoxxoTrystan FoxxoTrystan FoxxoTrystan approved these changes

@DEATHB4DEFEAT DEATHB4DEFEAT Awaiting requested review from DEATHB4DEFEAT DEATHB4DEFEAT is a code owner

@Aidenkrz Aidenkrz Awaiting requested review from Aidenkrz Aidenkrz was automatically assigned from Simple-Station/ee-writers

@Remuchi Remuchi Awaiting requested review from Remuchi Remuchi was automatically assigned from Simple-Station/ee-writers

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist Pspritechologist was automatically assigned from Simple-Station/ee-writers

@OldDanceJacket OldDanceJacket Awaiting requested review from OldDanceJacket OldDanceJacket was automatically assigned from Simple-Station/ee-writers

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Height/Width carries over when switching profile
3 participants
@sleepyyapril @VMSolidus @FoxxoTrystan