Fix Self-Aware Crashing Client #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
VMSolidus
approved these changes
Nov 18, 2024
DEATHB4DEFEAT
approved these changes
Nov 18, 2024
sleepyyapril
pushed a commit
to sleepyyapril/Einstein-Engines
that referenced
this pull request
Nov 18, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick fix to prevent the Self-Aware trait from crashing the client of a player when examining their character's health.
HealthExaminableSystem.CreateMarkupSelfAwareattempts to access theAnalyzableTypesandDetectableGroupsdata fields fromSelfAwareComponent, but since they are only initialized in the server andnullin the client, the client crashes. I believe this could be related to the recent trait overhauls, but not sure. I just fixed it by addingAutoNetworkedFieldto those fields to automatically propagate the initialized values. Other traits might have a similar bug to this.Changelog
🆑 Skubman