Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Catalyst #13

Open
marcosrdz opened this issue Jan 8, 2021 · 10 comments
Open

Mac Catalyst #13

marcosrdz opened this issue Jan 8, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@marcosrdz
Copy link
Contributor

Unable to compile with Mac Catalyst

Showing All Messages
Building for Mac Catalyst, but linking in dylib built for iOS Simulator, file 'Documents/GitHub/BlueWallet/node_modules/react-native-tor/ios/Libsifir_ios.framework/Libsifir_ios' for architecture x86_64

@gabidi
Copy link
Contributor

gabidi commented Jan 8, 2021

Zero testing was done on Catalyst. Focus was really iOS.

@marcosrdz
Copy link
Contributor Author

Is there documentation that I can follow in order to tackle this?

@Overtorment
Copy link
Contributor

@marcosrdz you probably want "Development and Building from Scratch" section from README, it has instructions on how to build rust code, then ios code, then typescript code

@gabidi
Copy link
Contributor

gabidi commented Jan 11, 2021

Hey @marcosrdz Thanks for offering to tackle this!

I'm not really well versed in Catalyst and thus not exactly sure what the error means, If you can give me your insight I would be able to better point you in the correct direction relative to this repo.

That said, from my limited understanding of the cryptic message seems like it's looking for an architecture that it's not finding or incorrectly linking to (?).
It could be simply that something needs to be added to the dylib headers or the Info.plist of the framework, if so this is done here:
https://github.com/Sifir-io/sifir-rs-sdk/blob/main/sifir-ios/scripts/into_framework.sh#L31-L59

Again if you would give me more context on what the error means relative to Catalyst I would probably be able to give you better information.

Thanks again!
G

@marcosrdz
Copy link
Contributor Author

marcosrdz commented Jan 11, 2021

BlueWallet/BlueWallet#2487

I have this branch ready to build so you can see the same error as I do.
Run: npm run maccatalystpatches
Open xcode, change the destination from an iPhone sim to "my mac" and press Run

@marcosrdz
Copy link
Contributor Author

https://stackoverflow.com/questions/58916615/how-do-i-build-for-mac-catalyst-x86-64-apple-ios-macabi

additional info

@gabidi
Copy link
Contributor

gabidi commented Jan 12, 2021

Will try building for this target, but considering it's Tier2 , i'm keeping my fingers crossed that dependencies used in the rs-sdk will build. I'll keep you posted.
Thanks !

@gabidi
Copy link
Contributor

gabidi commented Feb 28, 2021

Looks like This has been added as Tier3 on main channel Rust 1.5.0
rust-lang/rust#77484

Should be able to compile for this target now without _too much trouble_™

Will add todo.

@gabidi gabidi added the enhancement New feature or request label Feb 28, 2021
@marcosrdz
Copy link
Contributor Author

Any update on this issue?

@gabidi
Copy link
Contributor

gabidi commented May 7, 2021

on todo, Based on a number community requests I'm working on hidden services part of the module.
That said if anyone wants to take a stab at this in the meantime, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants