Skip to content
This repository has been archived by the owner on Sep 25, 2020. It is now read-only.

Fixed generated urls not matching webmocks for nil parameters. #1

Merged
merged 1 commit into from
Nov 30, 2015

Conversation

BenjaminSchaaf
Copy link
Contributor

When running the tests, WebMock would break for any API calls with nil parameters. The reason being, that WebMock would generate a slightly different URL to Typhoeus: (I've indicated the difference)

https://openapi.youku.com/v2/videos/show_batch.json?client_id=client-id&ext=&video_ids=123
                                                                           |
https://openapi.youku.com/v2/videos/show_batch.json?client_id=client-id&ext&video_ids=123

Changing the parameters from nil to '' to WebMock fixes this.

@avokhmin
Copy link
Contributor

👍

avokhmin added a commit that referenced this pull request Nov 30, 2015
Fixed generated urls not matching webmocks for `nil` parameters.
@avokhmin avokhmin merged commit c8e5540 into Shuttlerock-Archive:master Nov 30, 2015
@BenjaminSchaaf BenjaminSchaaf deleted the spec-fix branch November 30, 2015 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants