Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceList] Make EmptySearchResultWrapper responsive #2983

Merged
merged 4 commits into from
Jan 15, 2021

Conversation

kaelig
Copy link
Contributor

@kaelig kaelig commented May 13, 2020

WHY are these changes introduced?

Fixes an issue where user text zoom settings would be ignored by the empty search results wrapper.

WHAT is this pull request doing?

  • uses spacing tokens (which output values with rem units instead of px)
  • em-ifies the media query
  • uses min- instead of max-, like most of our media queries
  • changes the padding from 60px to 64px (extra-loose-spacing times 2)

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2020

🟢 This pull request modifies 2 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/ResourceList/ResourceList.scss (total: 1)

Files potentially affected (total: 1)

@kaelig kaelig force-pushed the responsive-EmptySearchResultWrapper branch from 4f35729 to 38472a1 Compare May 13, 2020 18:59
@kaelig kaelig requested a review from amrocha May 13, 2020 18:59
@alex-page alex-page force-pushed the master branch 2 times, most recently from 4eab9e5 to 9e09ba7 Compare January 15, 2021 05:17
@kaelig kaelig requested a review from alex-page January 15, 2021 22:02
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ty @kaelig

@kaelig kaelig merged commit b0fd0e3 into master Jan 15, 2021
@kaelig kaelig deleted the responsive-EmptySearchResultWrapper branch January 15, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants