Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multipass instructions for single fetch #2749

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

Updating the multipass example for single fetch upgrade instruction. This will cause the multipass example to generate this Remix error:

Screenshot 2025-02-06 at 2 07 28 PM

However, this error will go away after a future Remix patch release.

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Feb 11, 2025

Oxygen deployed a preview of your hl-fix-multipass-example branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment February 11, 2025 9:45 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment February 11, 2025 9:45 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment February 11, 2025 9:45 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment February 11, 2025 9:45 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment February 11, 2025 9:45 PM

Learn more about Hydrogen's GitHub integration.

@wizardlyhel wizardlyhel merged commit 49f997c into main Feb 12, 2025
11 checks passed
@wizardlyhel wizardlyhel deleted the hl-fix-multipass-example branch February 12, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants