Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about contrasting seasons #26

Open
PlekhanovaElena opened this issue Aug 9, 2024 · 0 comments
Open

Question about contrasting seasons #26

PlekhanovaElena opened this issue Aug 9, 2024 · 0 comments

Comments

@PlekhanovaElena
Copy link

Hi there,

I'm wondering about if the logic of contrasting different seasons work if the seasons are actually the same season.
In seco_dataset.py line 127

t0, t1, t2 = [read_image(path, self.bands, QUANTILES) for path in np.random.choice(sorted_paths, 3)]

but the default parameters of np.random.choice() are random.choice(a, size=None, replace=True, p=None), so it will choose with replacements by default. I was wondering if it would make more sense to use replace = False instead?

t0, t1, t2 = [read_image(path, self.bands, QUANTILES) for path in np.random.choice(sorted_paths, 3, replace = False)]

Otherwise, I would expect that the network would be posed with an impossible task of contrasting seasons which are actually the same season. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant