Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cs: Query for ZipSlip vulnerability (CVE-2018-1002200) #54

Merged
merged 6 commits into from
Aug 16, 2018

Conversation

denislevin
Copy link
Contributor

Initial check in to validate the tests

Initial check in to validate the tests
@denislevin denislevin requested a review from a team as a code owner August 13, 2018 22:00
@ghost
Copy link

ghost commented Aug 13, 2018

CLA assistant check
All committers have signed the CLA.

@calumgrant
Copy link
Contributor

I have created a pull request against your branch to fix the failing unit tests.
denislevin#1

Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! We can merge this once you have removed the @precision tag and the tests pass. @lukecartey has some further work on this and we can add qhelp as well.

csharp/ql/src/Security Features/CWE-022/ZipSlip.ql Outdated Show resolved Hide resolved
@denislevin
Copy link
Contributor Author

Removed @precision tag, merged unit test fixes from #1 branch

@lcartey
Copy link
Contributor

lcartey commented Aug 15, 2018

Thanks @denislevin. This is ready to merge apart from the CLA, which was updated this morning, so unfortunately you'll need to sign it again - sorry about that!

@denislevin
Copy link
Contributor Author

denislevin commented Aug 16, 2018 via email

@lcartey
Copy link
Contributor

lcartey commented Aug 16, 2018

@denislevin Sorry, I should have mentioned what changed. We've updated the formatting, and corrected our company name. You can see a full diff of the changes here:

https://gist.github.com/semmle-cla/577697e169c751bae58e29998f86a4f6/revisions

The CLA document is also available in the repository here:

https://github.com/Semmle/ql/blob/master/CONTRIBUTING.md

@semmle-qlci semmle-qlci merged commit 83c539a into github:master Aug 16, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Mark more AST predicates as `final`
smowton pushed a commit to smowton/codeql that referenced this pull request Oct 28, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants