-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cs: Query for ZipSlip vulnerability (CVE-2018-1002200) #54
Conversation
Initial check in to validate the tests
I have created a pull request against your branch to fix the failing unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! We can merge this once you have removed the @precision
tag and the tests pass. @lukecartey has some further work on this and we can add qhelp as well.
C#: Fix the unit tests for ZipSlip
Removed @precision tag, merged unit test fixes from #1 branch |
Thanks @denislevin. This is ready to merge apart from the CLA, which was updated this morning, so unfortunately you'll need to sign it again - sorry about that! |
@denislevin Sorry, I should have mentioned what changed. We've updated the formatting, and corrected our company name. You can see a full diff of the changes here: https://gist.github.com/semmle-cla/577697e169c751bae58e29998f86a4f6/revisions The CLA document is also available in the repository here: https://github.com/Semmle/ql/blob/master/CONTRIBUTING.md |
Mark more AST predicates as `final`
Kotlin: Accept test changes
New query: Singleton set literal.
New query: Singleton set literal.
Initial check in to validate the tests