Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup: pass scroll target as a prop #3569

Closed
averyga opened this issue Apr 15, 2019 · 9 comments · Fixed by #3607
Closed

Popup: pass scroll target as a prop #3569

averyga opened this issue Apr 15, 2019 · 9 comments · Fixed by #3607
Assignees
Labels

Comments

@averyga
Copy link

averyga commented Apr 15, 2019

Popup probably listening to the scroll of a window only. If popup in a div it stays on one position when scrolling the div. Would be great to have scroll target as a prop
I'm using 0.79.1 but the issue exists in the latest build.

Testcase

https://codesandbox.io/s/74mkmk5600

@welcome
Copy link

welcome bot commented Apr 15, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter changed the title Pass scroll target as a prop Popup: pass scroll target as a prop Apr 15, 2019
@layershifter
Copy link
Member

Should be checked after the 0.87.0 release, see #1126 (comment).

@layershifter
Copy link
Member

Checked, the issue is there 🤔 Fix is coming 🚀

@averyga
Copy link
Author

averyga commented Jul 16, 2019

@layershifter, was this released? I'm having the same issue on 0.87.3. Thanks

@layershifter
Copy link
Member

I have checked this on 0.87.3, https://codesandbox.io/s/semantic-ui-react-example-qkmtt
It works as was described in #3607.

@chloe-ha
Copy link

Hi @lafritay, seems like this issue is back on 2.0.3, https://codesandbox.io/s/semantic-ui-react-example-forked-3jl9z
Thanks

@lafritay
Copy link
Contributor

@chloehaDauphine I think that message may have been meant for @layershifter, just FYI

@chloe-ha
Copy link

Sorry @lafritay wrong tag! Yes the message was meant for @layershifter

@kaelhem
Copy link

kaelhem commented May 12, 2021

I'm facing the same issue on v2.0.3...
Is there some known workaround ?

With the codeandsandbox link posted by @chloehaDauphine, I played with boundary / rootBoundary / altBoundary popperModifiers params (like specified in popperJS doc), but without success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants