Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: add dimmer shorthand #2877

Closed
edvardsk opened this issue Jun 5, 2018 · 4 comments
Closed

Modal: add dimmer shorthand #2877

edvardsk opened this issue Jun 5, 2018 · 4 comments

Comments

@edvardsk
Copy link

edvardsk commented Jun 5, 2018

Feature Request

Modal portal class name option or any other possibility to style modals container.

Problem description

Right now there is no possibility to style default .modals portal via modal component. It is a big limitation, that reduce flexibility of the modal usage. The only one way to do it right now - it is overriding mountNode. But it is unnecessary and redundant in most cases.

Proposed solution

It will be great to have some prop in modal component, that will give possibility to add class to parent portal, something like portalClassName.

@welcome
Copy link

welcome bot commented Jun 5, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter changed the title Modals Modal: add dimmer shorthand Jun 6, 2018
@triage-new-issues triage-new-issues bot removed the triage label Jun 6, 2018
@layershifter
Copy link
Member

In fact, this can be done with #1739. However, there wasn't many activity. Will be easier to implement after #2880 will be merged.

@stale
Copy link

stale bot commented Dec 3, 2018

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Dec 3, 2018
@stale
Copy link

stale bot commented Jun 1, 2019

This issue will be closed due to lack of activity for 12 months. If you’d like this to be reopened, just leave a comment; we do monitor them!

@stale stale bot closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants