Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels Defined in Template not Loading "Label" Value #301

Closed
ZachMyers3 opened this issue Feb 21, 2021 · 5 comments
Closed

Labels Defined in Template not Loading "Label" Value #301

ZachMyers3 opened this issue Feb 21, 2021 · 5 comments

Comments

@ZachMyers3
Copy link
Contributor

ZachMyers3 commented Feb 21, 2021

When labels are defined in my custom templates the "value" of the labels is loaded but the "label" value is not. I have attached a screenshot of yacht recognizing the value but not the label and the accompanying JSON that I encountered this with. I followed this to set up the labels.

[
  {
    "type": 1,
    "title": "Beets",
    "name": "beets",
    "description": "The purpose of beets is to get your music collection right once and for all. It catalogs your collection, automatically improving its metadata as it goes using the MusicBrainz database. Then it provides a bouquet of tools for manipulating and accessing your music.",
    "logo": "https://raw.githubusercontent.com/SelfhostedPro/selfhosted_templates/master/Images/beets-icon.png",
    "image": "linuxserver/beets:latest",
    "categories": [
      "Music"
    ],
    "platform": "linux",
    "restart_policy": "unless-stopped",
    "volumes": [
      {
        "container": "/config",
        "bind": "!config/Beets"
      },
      {
        "container": "/downloads",
        "bind": "!downloads"
      },
      {
        "container": "/music",
        "bind": "!music"
      }
    ],
    "env": [
      {
        "name": "PUID",
        "label": "PUID",
        "default": "!PUID"
      },
      {
        "name": "PGID",
        "label": "PGID",
        "default": "!PGID"
      }
    ],
    "labels": [
      {
        "label": "traefik.http.services.beets.loadbalancer.server.scheme",
        "value": "http"
      },
      {
        "label": "traefik.http.services.beets.loadbalancer.server.port",
        "value": "8337"
      },
      {
        "label": "traefik.enable",
        "value": "true"
      },
      {
        "label": "traefik.docker.network",
        "value": "!traefik_network_name"
      },
      {
        "label": "traefik.http.routers.beets-http.service",
        "value": "beets"
      },
      {
        "label": "traefik.http.routers.beets-http.rule",
        "value": "Host(`beets.domain.tld`)"
      },
      {
        "label": "traefik.http.routers.beets-http.entrypoints",
        "value": "!traefik_http_name"
      },
      {
        "label": "traefik.http.routers.beets.service",
        "value": "beets"
      },
      {
        "label": "traefik.http.routers.beets.rule",
        "value": "Host(`beets.domain.tld`)"
      },
      {
        "label": "traefik.http.routers.beets.entrypoints",
        "value": "!traefik_https_name"
      },
      {
        "label": "traefik.http.routers.beets.tls",
        "value": "true"
      },
      {
        "label": "traefik.http.routers.beets.tls.certresolver",
        "value": "dns"
      },
      {
        "label": "traefik.http.routers.beets.tls.domains[0].main",
        "value": "!traefik_dns_domain"
      },
      {
        "label": "traefik.http.routers.beets.tls.domains[0].sans",
        "value": "!traefik_dns_sans_domain"
      }
    ]
  }
]

image

@SelfhostedPro
Copy link
Owner

Good catch! I'll get this sorted out shortly.

@ZachMyers3
Copy link
Contributor Author

Is it as simple as adjusting this from name to label? Not very familiar with the codebase.

@SelfhostedPro
Copy link
Owner

It'll probably need to be changed in the schema and in the form population function as well. I'll have some time this evening to take a look.

@SelfhostedPro
Copy link
Owner

Would you be able to test the :devel branch once it's done building?

https://github.com/SelfhostedPro/Yacht/runs/1948984842?check_suite_focus=true

It should be fixed.

@ZachMyers3
Copy link
Contributor Author

It looks like it is working on devel. Thanks!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants