fix: 🐛 Fields scroll behind form modal header #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields were going behind from modal header BREAKING CHANGE: 🧨 N ✅ Closes: #920
Mudassar-Raza
requested review from
20BBrown14,
laurelbean and
hvilander
as code owners
hvilander
approved these changes
Aug 21, 2023
|
@Mudassar-Raza If you put anything in the Breaking Change field when making a commit then it treats it like it is a breaking change. Can you please redo the commit and just press enter to skip the Breaking Change option? |
|
@laurelbean I made the commit with skipped breaking changes, kindly review it |
laurelbean
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields were going behind from modal header
When viewing a form modal, when you scroll a list of fields, the fields are scrolling on top of the header section.
AC:
When you scroll on a form modal the fields do not show in the header
Loom: https://www.loom.com/share/cc4810764e18427190b28f9cb84317d2?sid=900f374e-e0a9-405b-8363-303fec387d8a
✅ Closes: #920