feat: 🎸 SQFormGuidedWorkflow additional section #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we need to add a test case for this? On one hand, it's a new feature so it should probably add a test. On the other hand, I don't see how this feature would really change how a user uses Guided Workflow. Might be too close to testing implementation detail |
Ya, not sure that'd be useful. we're not testing any "displays x if y" scenarios with the contents of the guided workflow. Instead we test the workflow details (Click x opens section y, etc). |
SeanGroff
reviewed
Jan 21, 2022
SeanGroff
reviewed
Jan 21, 2022
| @@ -63,6 +64,7 @@ function SQFormGuidedWorkflow({ | |||
| useManageTaskModules(initialCompletedTasks, taskModulesContext); | |||
|
|
|||
| const transformedTaskModules = taskModules.map((taskModule, index) => { | |||
| console.log('taskModule', taskModule.additionalInformationSectionProps); | |||
SeanGroff
approved these changes
Jan 21, 2022
Added the ability for the SQFormGuidedWorkflow component to have an additional section above the agent script section. ✅ Closes: #586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability for the SQFormGuidedWorkflow component to have an
additional section above the agent script section.
✅ Closes: #586
Loom: https://www.loom.com/share/89ea19daa1ec4588bbc24ca2db0505c2