Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to MUIv5 #447

Closed
50 tasks done
SeanGroff opened this issue Sep 20, 2021 · 5 comments · Fixed by #816
Closed
50 tasks done

Migrate to MUIv5 #447

SeanGroff opened this issue Sep 20, 2021 · 5 comments · Fixed by #816
Assignees
@SeanGroff
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@SeanGroff
Copy link
Contributor

SeanGroff commented Sep 20, 2021 •
edited by 20BBrown14
Loading

Base Branch: issue-447/MUI5_migration

Example Component(s): LoadingIcon & LoadingSpinner

Migration Guides:

MUIv5 Migration
@SeanGroff SeanGroff added the discovery Further discovery is needed label Sep 20, 2021
@SeanGroff SeanGroff self-assigned this Sep 20, 2021
@codyarose
Copy link
Contributor

I'm guessing this should happen before the TS migration is merged since it seems like there are some improved types. And should scplus be upgraded to v5 before this as well since we have it as a dependency?

@SeanGroff
Copy link
Contributor Author

I'm guessing this should happen before the TS migration is merged since it seems like there are some improved types. And should scplus be upgraded to v5 before this as well since we have it as a dependency?

I need to perform discovery on the effects of migrating to v5.
Doing this prior to the TS Migration for better types would be the ideal path!

@SeanGroff SeanGroff added enhancement New feature or request help wanted Extra attention is needed and removed discovery Further discovery is needed labels Jun 20, 2022
@SeanGroff
Copy link
Contributor Author

We should be able to follow the same work and approach we're performing on SSC

@SeanGroff SeanGroff pinned this issue Jun 20, 2022
@20BBrown14
Copy link
Contributor

SOmeone added this Look into spacing issues on certain components (Ex: SQFormHelperText spacing on SQFormDialog Validation story). Whoever did that, could you expand on it and let us know what exactly you're seeing?

@aharpt
Copy link
Contributor

aharpt commented Sep 2, 2022

SOmeone added this Look into spacing issues on certain components (Ex: SQFormHelperText spacing on SQFormDialog Validation story). Whoever did that, could you expand on it and let us know what exactly you're seeing?

@20BBrown14 I added this. Here is a loom outlining what I am seeing. https://www.loom.com/share/01cb73296a2a4a92993191514f1dc2a2

@laurelbean laurelbean mentioned this issue Nov 14, 2022
Merged
@laurelbean laurelbean unpinned this issue Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanGroff SeanGroff

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to MUI v5 SelectQuoteLabs/SQForm
4 participants
@SeanGroff @aharpt @20BBrown14 @codyarose