Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: Error on IE 11 #49

Closed
babak-f opened this issue Oct 5, 2018 · 1 comment
Closed

[fix]: Error on IE 11 #49

babak-f opened this issue Oct 5, 2018 · 1 comment

Comments

@babak-f
Copy link

babak-f commented Oct 5, 2018

My setup consists of webpack (with vue loader) and babel, for transpiling JavaScript into previous ES versions.

In IE 11 I get the following error on the following line of the output JavaScript file. The error points at the 378th character in the line.

Expected ':'

Object.defineProperty(_exports,"__esModule",{value:!0}),_exports.default=void 0;var _default={install(Vue,options){Object.defineProperties(Vue.prototype,{$breadcrumbs:{get(){var _this=this,breadcrumbs=this.$route.matched.map(function(routeRecord){var path=routeRecord.path.length?routeRecord.path:"/",route=routeRecord;return Object.keys(_this.$route.params).forEach(function(param){path=route.path.replace(":"+param,_this.$route.params[param])},_this),route.path=path,route},this);return breadcrumbs}}});Vue.component("breadcrumbs",Object.assign({methods:{getBreadcrumb:function getBreadcrumb(bc){return"function"==typeof bc?bc(this.$route.params):bc}},template:`

As a result, the entire page fails to load.

I assume that babel has taken care of transpiling the script to a version compatible with IE 11, so I guess it's the breadcrumb code itself that is causing the issue. Just a guess though ;)

Module version used: latest so far (0.4.0)

@Scrum
Copy link
Owner

Scrum commented Oct 17, 2018

@babak-f Hi, I see no reason to support outdated browsers. If you have a solution I will always consider it. Send your pull requests

@Scrum Scrum added this to the 0.4.1 milestone Oct 17, 2018
@Scrum Scrum changed the title Error on IE 11 [fix]: Error on IE 11 Oct 17, 2018
@Scrum Scrum modified the milestones: 0.4.1, 0.4.2 Jan 10, 2019
@Scrum Scrum modified the milestones: 0.4.2, 0.5.1 Feb 6, 2019
@Scrum Scrum closed this as completed in 36a5638 Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants