Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Escape character not available in PowerShell 5.1 #5869

Closed
amorphobia opened this issue Apr 8, 2024 · 1 comment · Fixed by #5424
Closed

[Bug] Escape character not available in PowerShell 5.1 #5869

amorphobia opened this issue Apr 8, 2024 · 1 comment · Fixed by #5424
Labels
bug

Comments

@amorphobia
Copy link
Contributor

Bug Report

Current Behavior

virustotal command uses ANSI escape sequences ( `e[) to print colored warning messages, but the escape character `e is added in PowerShell 6 (PowerShell docs).

PS> scoop virustotal plain-craft-launcher
WARN  e[31msiku/plain-craft-launcher: 24/67, see https://www.virustotal.com/gui/file/c19757eafa13f0d9d4e2bc5278b9bfa2e86c37fe79b8b4c928aed9353a3f025ae[0m

Expected Behavior

Print text and color correctly.

expected

Possible Solution

Use $([char]0x1b) instead.

System details

Windows version: 10

OS architecture: 64bit

PowerShell version:

Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      20348  2227

Scoop Configuration

Irrelevant
@amorphobia amorphobia added the bug label Apr 8, 2024
@amorphobia
Copy link
Contributor Author

I'll submit a pull request for it

@amorphobia amorphobia mentioned this issue Apr 8, 2024
Merged
5 tasks
@niheaven niheaven mentioned this issue Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(release): Bump to version 0.4.0 ScoopInstaller/Scoop
1 participant
@amorphobia