[Bug] Shims fail if path contains spaces

[jbtls]

Bug Report

git

Current Behaviour

Scoop is unable to run command: "Could not create process with command <...>"

Expected Behaviour

Scoop should update

Additional context/output

My username has a space in between.

Possible Solution

The git shim should be updated to:
path = "C:\Users\User Name\scoop\apps\git\current\cmd\git.exe"

System details

Windows version: 11

OS architecture: 64bit

**PowerShell version:**5.1.22000.282

Scoop Configuration

{
    "lastupdate":  "2022-01-27T14:48:14.5181152+01:00",
    "SCOOP_REPO":  "https://github.com/lukesampson/scoop",
    "SCOOP_BRANCH":  "master"
}

[niheaven]

What if you change scoop to 'develop'?

scoop config SCOOP_BRANCH develop
scoop update
scoop reset git

[jbtls]

Same problem. I've just changed the shim myself and it works with the solution given above.

Possible Solution

The git shim should be updated to:
path = "C:\Users\User Name\scoop\apps\git\current\cmd\git.exe"

[niheaven]

Have you tested path = "C:\Users\User Name\scoop\apps\git\current\cmd\git.exe"? If so, I'll fix it. Sorry for not having suitable environment to test myself.

[jbtls]

Yes, and it works! I've just realized that this problem affects multiple shims (yt-dlp, ffmpeg, ...). It should get fixed there too.

[rashil2000]

I'm not able to reproduce this issue. My .shim files have paths with spaces and don't require double quotes.

Can you try these step:

scoop config shim kiennq
scoop update
scoop reset git

[niheaven]

Maybe it's the bug of default shimexe? If so, it should be fixed.

[rashil2000]

Maybe it's the bug of default shimexe? If so, it should be fixed.

We changed the default shim to kiennq some months ago, so that's not likely.

[jbtls]

Hey, sorry for not answering fast.
For me, it seems like it has happened to all shims….

[JcobCN]

i got the same problem, that may be related to python env.
I have installed Anaconda, and conda command get the same problem "failed to create process".
Does scoop used python?

[JcobCN]

scoop config SCOOP_BRANCH fix-shim
scoop update
scoop reset git
git works well, and need reset all apps.

[rashil2000]

Does scoop used python?

It doesn't.

Does your username contain special/accented characters?

[JcobCN]

Yes, I modified Scoop installed path at "D:\Program Files\Scoop", so shim path contain spaces character.

OS: windows 10

[JcobCN]

Yes, I modified Scoop installed path at "D:\Program Files\Scoop", so shim path contain spaces character.

OS: windows 10

Before today, Scoop works well.

[rashil2000]

Here's my environment:

Can you try using the develop branch once?

scoop config SCOOP_BRANCH develop
scoop update
scoop reset git

[JcobCN]

Here's my environment:

Can you try using the develop branch once?

scoop config SCOOP_BRANCH develop
scoop update
scoop reset git

using the develop, but does not work.

[JcobCN]

@jbehmel Have you installed MSVC build tools recently?

[JcobCN]

@rashil2000 I think some windows setting changed, My app, windows Terminal, has the same problem, must add " in the path.

Before install MSVC Buildtools, it works well, Scoop works well, and Anaconda works well.
MSVC Buildtools change some OS setting?

[rashil2000]

I also have MSVC build tools installed, since a long time now.

[rashil2000]

For Windows Terminal you will need double quotes because it's json and the binary path has spaces.

[JcobCN]

For Windows Terminal you will need double quotes because it's json and the binary path has spaces.

before that, my setting is

and work well.

and now, my setting need add quotes to contain the spaces path.

[rashil2000]

Could you try uninstalling MSVC tools to confirm if that is causing this problem?

[niheaven]

If adding quotes doesn't introduce a new bug, #4734 could be merged.

[rashil2000]

Could you try uninstalling MSVC tools to confirm if that is causing this problem?

@JcobCN any updates on this?

[vieiraa]

Fixed by #4767.
Will need to run

scoop reset *

to use the fixed shim.exe.

[rashil2000]

Closed in #4734