Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot download files from portableapps.com #3960

Closed
ghost opened this issue May 5, 2020 · 2 comments · Fixed by #3961
Closed

cannot download files from portableapps.com #3960

ghost opened this issue May 5, 2020 · 2 comments · Fixed by #3961

Comments

@ghost
Copy link

ghost commented May 5, 2020

I attempt to install some portable software (e.g. https://github.com/NilsonPark/scoop-portableapps/blob/master/bucket/LibreOfficePortable.json, https://github.com/NilsonPark/scoop-portableapps/blob/master/bucket/OpenOfficePortable.json). These files are large but can be downloaded in seconds. However, the hash check is always incorrect and inconsistent. The download files are incomplete and much smaller.

If I paste the download URLs to browsers, I can download the files correctly. I cannot figure out what is wrong. Thank you.

@ghost
Copy link
Author

ghost commented May 5, 2020

The output is shown as below.
scoop

I locate the problem at Line 382 of install.ps1 (https://github.com/lukesampson/scoop/blob/master/lib/install.ps1#L382). It seems the files are not correctly downloaded.

@ghost
Copy link
Author

ghost commented May 5, 2020

Finally, figure out what happens. If one want to download from portableapps.com, the referer should be empty.

@r15ch13 originally found this trick and fixed this issue at this commit.

@nickbudi removed this setting at pull request #2401 since he found Portableapps.com switched its host to portableapps.duckduckgo.com and strip_filename is no longer required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants