Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additonal tests for certificate consistency on update cmds #4556

Closed
Tracked by #4567 ...
touilleMan opened this issue May 15, 2023 · 1 comment
Closed
Tracked by #4567 ...

Additonal tests for certificate consistency on update cmds #4556

touilleMan opened this issue May 15, 2023 · 1 comment
Labels
I-Python Impact: Python-related stuff I-Test Test-related issue
Milestone

Comments

@touilleMan
Copy link
Member

APIv4 has modified the way we upload certificates:

All commands related to modification now must ensure causality with the certificates
(and also vlobs) already in the server. For this two errors can be returned:

  • status: bad_timestamp: "Out of ballpark" error, the clock between client and server
    is broken (in API<v4 this error was not differentiate from the certificate is invalid,
    which is bad given we most likely want to explain to the user that his clock is wrong)
  • status: require_greater_timestamp: causality error

Impacted commands:

  • pki_enrollment_accept
  • realm_update_roles
  • user_create
  • user_revoke
  • realm_create
  • user_update
  • vlob_create
  • vlob_update

This is some pretty sensitive stuff, so we need extra tests on those points !

Make sure on insertion, new certificate creation date > latest certif creation date.
So strictly greater, otherwise created_after param in certificate_get may skip
some certificates that append in the same timestamp (need to add tests to check that !)

Related to #4552

@touilleMan touilleMan added I-Python Impact: Python-related stuff I-Test Test-related issue labels May 15, 2023
@touilleMan touilleMan changed the title [:boxing_glove: :1st_place_medal: Additonal tests for certificate consistency on update cmds [:boxing_glove: :1st_place_medal: Final oxidation] Additonal tests for certificate consistency on update cmds May 16, 2023
@FirelightFlagboy FirelightFlagboy changed the title [:boxing_glove: :1st_place_medal: Final oxidation] Additonal tests for certificate consistency on update cmds [:boxing_glove: :snake: :1st_place_medal: Final oxidation] Additonal tests for certificate consistency on update cmds May 17, 2023
@touilleMan touilleMan changed the title [:boxing_glove: :snake: :1st_place_medal: Final oxidation] Additonal tests for certificate consistency on update cmds Additonal tests for certificate consistency on update cmds Jan 29, 2024
@touilleMan touilleMan added this to the v3.0 milestone Jan 29, 2024
@mmmarcos mmmarcos mentioned this issue Feb 9, 2024
37 tasks
@mmmarcos mmmarcos modified the milestones: v3.0-beta, v3.0 Mar 27, 2024
@touilleMan
Copy link
Member Author

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-Python Impact: Python-related stuff I-Test Test-related issue
Projects
None yet
Development

No branches or pull requests

2 participants