Add imagehash v4 links #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2018
|
FWIW, you don't need to worry about the git repository size when you have two identical files in a repository: https://stackoverflow.com/a/29949004/741316 It definitely helps for user checkouts though... |
pelson
approved these changes
Apr 11, 2018
| @@ -15,7 +15,7 @@ class TestHash(unittest.TestCase): | |||
| def test(self): | |||
| self.maxDiff = None | |||
| exceptions = [] | |||
| for fname in glob.glob("images/*.png"): | |||
| for fname in glob.glob("images/v4/*.png"): | |||
| phash = imagehash.phash(Image.open(fname), hash_size=_HASH_SIZE) | |||
There was a problem hiding this comment.
Do we have the ability to pass the phash version to the function, or does imagehash not maintain backwards compatible image hashing functionality?
There was a problem hiding this comment.
It's a breaking change moving to v4. There's no way to generate the old hash from v4, hence the test coverage is only on the new images using the new imagehash v4.
To test the old hashes we'd need to install the pre-v4 imagehash ... and I'm kinda loathed to do that. Is that a safe approach to take?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all of the relevant
images/*.pngfrom old hash filenames to newimagehash 4.0hash filenames within theimages/v4directory.In order not to unnecessarily bloat the repo, the new hash filenames link to their associated old hash filename.
Note that, the new hash filename
fa81857e857e7a81857e7a817a81857a7a81857e857e7a85857e7a817a81857a.pnghas been added to correct a new failing test.