From 837eb72264a03985fed9b9f51dd5c229c6a8a114 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 11:42:07 +0000 Subject: [PATCH 01/39] Create test2.yml --- .github/workflows/test2.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/test2.yml diff --git a/.github/workflows/test2.yml b/.github/workflows/test2.yml new file mode 100644 index 0000000000..5df8a23da8 --- /dev/null +++ b/.github/workflows/test2.yml @@ -0,0 +1,23 @@ +name: hello world2 +on: + schedule: + # * is a special character in YAML so you have to quote this string + - cron: '43 * * * *' + workflow_dispatch: + inputs: + name: + description: 'Person to greet' + required: true + default: 'Mona the Octocat' + home: + description: 'location' + required: false + default: 'The Octoverse' + +jobs: + say_hello: + runs-on: ubuntu-latest + steps: + - run: | + echo "Hello ${{ github.event.inputs.name }}!" + echo "- in ${{ github.event.inputs.home }}!" From 04e26cad5acce0403df525309483b89395c586e0 Mon Sep 17 00:00:00 2001 From: Tremain Knight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 12:03:52 +0000 Subject: [PATCH 02/39] gha test --- .github/workflows/refresh-votable-issues.yml | 26 ++++++++++++++++++++ .github/workflows/test2.yml | 23 ----------------- 2 files changed, 26 insertions(+), 23 deletions(-) create mode 100644 .github/workflows/refresh-votable-issues.yml delete mode 100644 .github/workflows/test2.yml diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml new file mode 100644 index 0000000000..6e27d3f0aa --- /dev/null +++ b/.github/workflows/refresh-votable-issues.yml @@ -0,0 +1,26 @@ +# Uses Github API to get a list of issues that have votes on and then +# update a gist with the results in json + +name: Refresh Votable Issues +on: + workflow_dispatch: + branches: [ votable_issues ] +jobs: + votable_main: + runs-on: ubuntu-latest + steps: + # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it + - name: Checkout + run: echo "Hello World!" + +# uses: actions/checkout@v2 +# with: +# path: main + +# - uses: actions/script@v4 +# with: +# github-token: ${{ secrets.GITHUB_TOKEN }} +# script: | +# echo "hello world" +# docs/src/query_gh_votable_issues.py ${{ secrets.GITHUB_TOKEN }} +# cat votable-issues.json diff --git a/.github/workflows/test2.yml b/.github/workflows/test2.yml deleted file mode 100644 index 5df8a23da8..0000000000 --- a/.github/workflows/test2.yml +++ /dev/null @@ -1,23 +0,0 @@ -name: hello world2 -on: - schedule: - # * is a special character in YAML so you have to quote this string - - cron: '43 * * * *' - workflow_dispatch: - inputs: - name: - description: 'Person to greet' - required: true - default: 'Mona the Octocat' - home: - description: 'location' - required: false - default: 'The Octoverse' - -jobs: - say_hello: - runs-on: ubuntu-latest - steps: - - run: | - echo "Hello ${{ github.event.inputs.name }}!" - echo "- in ${{ github.event.inputs.home }}!" From 6becc0aec692ac00078dcbd1bdcc3d5176101c01 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 14:55:35 +0000 Subject: [PATCH 03/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 6e27d3f0aa..ff20c181fe 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -13,9 +13,15 @@ jobs: - name: Checkout run: echo "Hello World!" -# uses: actions/checkout@v2 -# with: -# path: main + uses: actions/checkout@v2 + with: + repository: tkknight/iris + path: iris + + uses: actions/checkout@v2 + with: + repository: SciTools-incubator/scitools-cla-checker + path: scitools-cla-checker # - uses: actions/script@v4 # with: From 2476aa81fdc9bc93f023512abd61c95d16ccf4dc Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 15:02:16 +0000 Subject: [PATCH 04/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index ff20c181fe..d7746722b3 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -10,14 +10,16 @@ jobs: runs-on: ubuntu-latest steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - name: Checkout + - name: echo test run: echo "Hello World!" + - name: chekcout iris uses: actions/checkout@v2 with: repository: tkknight/iris path: iris - + + - name: chekcout the file to update uses: actions/checkout@v2 with: repository: SciTools-incubator/scitools-cla-checker From 4cd47bdff568c441e50184334a77acf1fd416b08 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 15:11:25 +0000 Subject: [PATCH 05/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index d7746722b3..0a4d6a4d6b 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -13,18 +13,12 @@ jobs: - name: echo test run: echo "Hello World!" - - name: chekcout iris + - name: checkout iris uses: actions/checkout@v2 with: repository: tkknight/iris path: iris - - name: chekcout the file to update - uses: actions/checkout@v2 - with: - repository: SciTools-incubator/scitools-cla-checker - path: scitools-cla-checker - # - uses: actions/script@v4 # with: # github-token: ${{ secrets.GITHUB_TOKEN }} From c58834b383b7bc77afd6e75417f72144ee1c6ca5 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 15:16:19 +0000 Subject: [PATCH 06/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 0a4d6a4d6b..ddaa8f6f5d 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -11,13 +11,13 @@ jobs: steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - name: echo test - run: echo "Hello World!" + run: echo "Hello World!";ls -al - - name: checkout iris - uses: actions/checkout@v2 - with: - repository: tkknight/iris - path: iris +# - name: checkout iris +# uses: actions/checkout@v2 +# with: +# repository: tkknight/iris +# path: iris # - uses: actions/script@v4 # with: From 08094be1bb7a0bb9eb18702888a1a726a0d54b95 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 15:17:59 +0000 Subject: [PATCH 07/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index ddaa8f6f5d..55e4409e4f 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -9,15 +9,15 @@ jobs: votable_main: runs-on: ubuntu-latest steps: - # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - name: echo test - run: echo "Hello World!";ls -al - -# - name: checkout iris -# uses: actions/checkout@v2 -# with: -# repository: tkknight/iris -# path: iris + run: echo "ls command";ls -al + + # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it + - name: checkout iris + uses: actions/checkout@v2 + with: + repository: tkknight/iris + path: iris # - uses: actions/script@v4 # with: @@ -26,3 +26,6 @@ jobs: # echo "hello world" # docs/src/query_gh_votable_issues.py ${{ secrets.GITHUB_TOKEN }} # cat votable-issues.json + + - name: echo test + run: echo "Hello World!" From 5e22ee3fadf7f775960066a1f83d8d2e97ced5b5 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 15:20:35 +0000 Subject: [PATCH 08/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 55e4409e4f..73e13f1897 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -19,13 +19,13 @@ jobs: repository: tkknight/iris path: iris -# - uses: actions/script@v4 -# with: + - uses: actions/script@v4 + with: # github-token: ${{ secrets.GITHUB_TOKEN }} -# script: | -# echo "hello world" -# docs/src/query_gh_votable_issues.py ${{ secrets.GITHUB_TOKEN }} -# cat votable-issues.json + script: | + echo "hello world" + python iris/docs/src/query_gh_votable_issues.py ${{ secrets.GITHUB_TOKEN }} + cat votable-issues.json - name: echo test run: echo "Hello World!" From d8ae094f7bd0311cc84ae1230b718654d087d4b0 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:20:12 +0000 Subject: [PATCH 09/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 31 +++++++++++++++----- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 73e13f1897..541d4fe2e2 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -19,13 +19,30 @@ jobs: repository: tkknight/iris path: iris - - uses: actions/script@v4 - with: -# github-token: ${{ secrets.GITHUB_TOKEN }} - script: | - echo "hello world" - python iris/docs/src/query_gh_votable_issues.py ${{ secrets.GITHUB_TOKEN }} - cat votable-issues.json + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Set up Python 3.9 + uses: actions/setup-python@v2 + with: + python-version: 3.9 + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install PyGithub + - name: Run the python + run: | + python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} + +# - uses: actions/script@v4 +# with: +# github-token: ${{ secrets.GITHUB_TOKEN }} +# script: | +# echo "hello world" +# python iris/docs/src/query_gh_votable_issues.py ${{ secrets.GITHUB_TOKEN }} +# cat votable-issues.json +# - name: echo test run: echo "Hello World!" From 7d7ede4c3d42a743638fbad99afed4400fd505cf Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:22:52 +0000 Subject: [PATCH 10/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 541d4fe2e2..4b3ac70dc0 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -31,7 +31,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install PyGithub + pip install PyGithub - name: Run the python run: | python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} From 23d5afd8286b83ee0650ddaeba23ae24300d7706 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:23:49 +0000 Subject: [PATCH 11/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 4b3ac70dc0..2912ed5bf8 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -31,7 +31,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install PyGithub +# pip install PyGithub - name: Run the python run: | python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} @@ -45,4 +45,4 @@ jobs: # cat votable-issues.json # - name: echo test - run: echo "Hello World!" + run: echo "Hello World!";ls -al $GITHUB_WORKSPACE From bc1c3a2a1497b9a31a0d1c005fc54ffb5b078436 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:25:38 +0000 Subject: [PATCH 12/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 2912ed5bf8..ceea43c3c0 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -23,7 +23,6 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - name: Set up Python 3.9 uses: actions/setup-python@v2 with: From 7082c1219c827c37fcdba2e1e1e6c0009b557fd5 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:26:19 +0000 Subject: [PATCH 13/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index ceea43c3c0..6ed679f078 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -27,9 +27,9 @@ jobs: uses: actions/setup-python@v2 with: python-version: 3.9 - - name: Install dependencies - run: | - python -m pip install --upgrade pip +# - name: Install dependencies +# run: | +# python -m pip install --upgrade pip # pip install PyGithub - name: Run the python run: | From 1337a9123179744f45125e51271555d518379673 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:26:44 +0000 Subject: [PATCH 14/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 6ed679f078..3e275ae540 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -31,9 +31,11 @@ jobs: # run: | # python -m pip install --upgrade pip # pip install PyGithub - - name: Run the python - run: | - python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} +# - name: Run the python +# run: | +# python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} + + # - uses: actions/script@v4 # with: From 73f8de74687ab363dbdff5e7feb1939df6999eb0 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:27:27 +0000 Subject: [PATCH 15/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 3e275ae540..8490fe37e7 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -20,13 +20,13 @@ jobs: path: iris - build: - runs-on: ubuntu-latest - steps: - - name: Set up Python 3.9 - uses: actions/setup-python@v2 - with: - python-version: 3.9 +# build: +# runs-on: ubuntu-latest +# steps: +# - name: Set up Python 3.9 +# uses: actions/setup-python@v2 +# with: +# python-version: 3.9 # - name: Install dependencies # run: | # python -m pip install --upgrade pip From bc016bd6d82c1c1d264119ef62831935bb8e556e Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:28:54 +0000 Subject: [PATCH 16/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 8490fe37e7..6613d2187d 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -9,9 +9,7 @@ jobs: votable_main: runs-on: ubuntu-latest steps: - - name: echo test - run: echo "ls command";ls -al - + # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - name: checkout iris uses: actions/checkout@v2 @@ -46,4 +44,4 @@ jobs: # cat votable-issues.json # - name: echo test - run: echo "Hello World!";ls -al $GITHUB_WORKSPACE + run: echo "Hello World!";ls -al $GITHUB_WORKSPACE/iris From 15a05a95a002c1b02262535aceb2306e2d758aff Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:30:01 +0000 Subject: [PATCH 17/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 6613d2187d..e4049ba0f1 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -44,4 +44,4 @@ jobs: # cat votable-issues.json # - name: echo test - run: echo "Hello World!";ls -al $GITHUB_WORKSPACE/iris + run: echo "Hello World!";ls -al $GITHUB_WORKSPACE/iris/docs/src From 08c2fb31bc1a76096c3285a76757b5fbf146c8e5 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:32:45 +0000 Subject: [PATCH 18/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index e4049ba0f1..069b34867a 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -15,6 +15,7 @@ jobs: uses: actions/checkout@v2 with: repository: tkknight/iris + ref: votable_issues path: iris From c58d6ad79d75003bd47e83e4c0b6a02a0e0796b9 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:35:32 +0000 Subject: [PATCH 19/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 069b34867a..b3494945ed 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -18,6 +18,17 @@ jobs: ref: votable_issues path: iris + - name: Set up Python 3.9 + uses: actions/setup-python@v2 + with: + python-version: 3.9 +# - name: Install dependencies +# run: | +# python -m pip install --upgrade pip +# pip install PyGithub +# - name: Run the python +# run: | +# python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} # build: # runs-on: ubuntu-latest From 737ea8ae57fb6de828862bb681f7a15c0164a937 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:37:22 +0000 Subject: [PATCH 20/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index b3494945ed..a5176af588 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -22,10 +22,11 @@ jobs: uses: actions/setup-python@v2 with: python-version: 3.9 -# - name: Install dependencies -# run: | -# python -m pip install --upgrade pip -# pip install PyGithub + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install PyGithub + # - name: Run the python # run: | # python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} From 192b52089762b618ee808dac1809c700c7de1b24 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:38:43 +0000 Subject: [PATCH 21/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index a5176af588..0ea171b745 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -8,8 +8,7 @@ on: jobs: votable_main: runs-on: ubuntu-latest - steps: - + steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - name: checkout iris uses: actions/checkout@v2 @@ -17,7 +16,8 @@ jobs: repository: tkknight/iris ref: votable_issues path: iris - + + # setup python - name: Set up Python 3.9 uses: actions/setup-python@v2 with: @@ -27,9 +27,9 @@ jobs: python -m pip install --upgrade pip pip install PyGithub -# - name: Run the python -# run: | -# python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} + - name: Run the python + run: | + python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} # build: # runs-on: ubuntu-latest From f4af40290ea2706a645a419820338992ede79cf7 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:40:36 +0000 Subject: [PATCH 22/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 0ea171b745..1c0824e310 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -29,7 +29,7 @@ jobs: - name: Run the python run: | - python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} + python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} # build: # runs-on: ubuntu-latest From 586ca36b4d11f301f7624f78657a1f990973d50b Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:44:40 +0000 Subject: [PATCH 23/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 34 +++----------------- 1 file changed, 5 insertions(+), 29 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 1c0824e310..0267e1aa21 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -26,35 +26,11 @@ jobs: run: | python -m pip install --upgrade pip pip install PyGithub - + # run the python scripts passing in the github token + # TODO: this seems to run ok without any API token? - name: Run the python run: | + ls -al ls -al $GITHUB_WORKSPACE/iris/docs/src python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} - -# build: -# runs-on: ubuntu-latest -# steps: -# - name: Set up Python 3.9 -# uses: actions/setup-python@v2 -# with: -# python-version: 3.9 -# - name: Install dependencies -# run: | -# python -m pip install --upgrade pip -# pip install PyGithub -# - name: Run the python -# run: | -# python ${{ github.action_path }}/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} - - - -# - uses: actions/script@v4 -# with: -# github-token: ${{ secrets.GITHUB_TOKEN }} -# script: | -# echo "hello world" -# python iris/docs/src/query_gh_votable_issues.py ${{ secrets.GITHUB_TOKEN }} -# cat votable-issues.json -# - - name: echo test - run: echo "Hello World!";ls -al $GITHUB_WORKSPACE/iris/docs/src + ls -al ls -al $GITHUB_WORKSPACE/iris/docs/src + From 5a2c6f825599ca70a4586345f4caa9fb1f3aa66a Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:45:49 +0000 Subject: [PATCH 24/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 0267e1aa21..a9e3eeb210 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -30,7 +30,7 @@ jobs: # TODO: this seems to run ok without any API token? - name: Run the python run: | - ls -al ls -al $GITHUB_WORKSPACE/iris/docs/src + ls -al $GITHUB_WORKSPACE/iris/docs/src python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} - ls -al ls -al $GITHUB_WORKSPACE/iris/docs/src + ls -al $GITHUB_WORKSPACE/iris/docs/src From 8ddc02e9e0d47f74dbefffe4f21dc2dd74757f88 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:51:26 +0000 Subject: [PATCH 25/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index a9e3eeb210..eea41e7d86 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -33,4 +33,5 @@ jobs: ls -al $GITHUB_WORKSPACE/iris/docs/src python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} ls -al $GITHUB_WORKSPACE/iris/docs/src + ls -al $GITHUB_WORKSPACE From 46f574e56133dd7e1d4afec2bee7c07bbcc0bea5 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 16:54:45 +0000 Subject: [PATCH 26/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index eea41e7d86..00b14d3822 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -30,8 +30,6 @@ jobs: # TODO: this seems to run ok without any API token? - name: Run the python run: | - ls -al $GITHUB_WORKSPACE/iris/docs/src python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} - ls -al $GITHUB_WORKSPACE/iris/docs/src ls -al $GITHUB_WORKSPACE From 954d5d71bf9a86db4129b68d47a547d368a449ce Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 17:01:49 +0000 Subject: [PATCH 27/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 00b14d3822..b054f7fb88 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -30,6 +30,7 @@ jobs: # TODO: this seems to run ok without any API token? - name: Run the python run: | - python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ${{ secrets.gh_token }} + export GH_TOKEN=${{ secrets.GITHUB_TOKEN }} + python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ls -al $GITHUB_WORKSPACE From ac506f2b74c82c426f21cdeb7af8d102efffb354 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 17:13:18 +0000 Subject: [PATCH 28/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index b054f7fb88..28a8d2e540 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -9,14 +9,22 @@ jobs: votable_main: runs-on: ubuntu-latest steps: - # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it + # Checks-out your repositories under $GITHUB_WORKSPACE, so your job can access it - name: checkout iris uses: actions/checkout@v2 with: repository: tkknight/iris ref: votable_issues path: iris - + + - name: checkout the repo with the json to update + uses: actions/checkout@v2 + with: + # TODO: use the proper repo! + repository: SciTools-incubator/scitools-cla-checker + ref: main + path: scitools-cla-checker + # setup python - name: Set up Python 3.9 uses: actions/setup-python@v2 From 492e00ca8fa7d6817d21ac0a3af073e6ea13672d Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 17:14:50 +0000 Subject: [PATCH 29/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 28a8d2e540..cd0a5134b9 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -22,7 +22,7 @@ jobs: with: # TODO: use the proper repo! repository: SciTools-incubator/scitools-cla-checker - ref: main + ref: master path: scitools-cla-checker # setup python From 1b6ff8f7f7075e95e74c6c902cf0a83b729dde1c Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 17:23:40 +0000 Subject: [PATCH 30/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index cd0a5134b9..69135c4d4d 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -21,9 +21,9 @@ jobs: uses: actions/checkout@v2 with: # TODO: use the proper repo! - repository: SciTools-incubator/scitools-cla-checker - ref: master - path: scitools-cla-checker + repository: tkknight/votable_issues + ref: main + path: votable_issues # setup python - name: Set up Python 3.9 From 3a9e1ed859fea31c0b65654d0d81d0a7c29729b3 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 17:27:11 +0000 Subject: [PATCH 31/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 69135c4d4d..731a1e0fc7 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -35,10 +35,9 @@ jobs: python -m pip install --upgrade pip pip install PyGithub # run the python scripts passing in the github token - # TODO: this seems to run ok without any API token? - name: Run the python run: | export GH_TOKEN=${{ secrets.GITHUB_TOKEN }} python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ls -al $GITHUB_WORKSPACE - + # update the reop with the new file, try https://github.com/marketplace/actions/update-files-on-github From 7b6c3fedb10283aeee9e12d8c75d00271ac1c9bf Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Mon, 10 Jan 2022 18:51:23 +0000 Subject: [PATCH 32/39] Update refresh-votable-issues.yml --- .github/workflows/refresh-votable-issues.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml index 731a1e0fc7..1c08bd4a2d 100644 --- a/.github/workflows/refresh-votable-issues.yml +++ b/.github/workflows/refresh-votable-issues.yml @@ -41,3 +41,4 @@ jobs: python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py ls -al $GITHUB_WORKSPACE # update the reop with the new file, try https://github.com/marketplace/actions/update-files-on-github + # JP suggests: https://github.com/MetOffice/ssstack/blob/main/.github/workflows/publish-docs.yml From 7e494b0534b29661eec5ba6585d51ca8b62bee97 Mon Sep 17 00:00:00 2001 From: Tremain Knight <2108488+tkknight@users.noreply.github.com> Date: Wed, 2 Mar 2022 17:10:35 +0000 Subject: [PATCH 33/39] initial --- docs/src/common_links.inc | 1 + docs/src/conf.py | 11 ++++++++ docs/src/index.rst | 1 + docs/src/votable_issues.rst | 55 +++++++++++++++++++++++++++++++++++++ docs/src/whatsnew/dev.rst | 3 +- 5 files changed, 70 insertions(+), 1 deletion(-) create mode 100644 docs/src/votable_issues.rst diff --git a/docs/src/common_links.inc b/docs/src/common_links.inc index 67fc493e3e..f8f8e76384 100644 --- a/docs/src/common_links.inc +++ b/docs/src/common_links.inc @@ -38,6 +38,7 @@ .. _using git: https://docs.github.com/en/github/using-git .. _requirements/ci/: https://github.com/SciTools/iris/tree/main/requirements/ci .. _CF-UGRID: https://ugrid-conventions.github.io/ugrid-conventions/ +.. _votable issues on GitHub: https://github.com/SciTools/iris/issues?q=is%3Aopen+is%3Aissue+label%3A%22Feature%3A+Votable%22+sort%3Areactions-%2B1-desc .. comment diff --git a/docs/src/conf.py b/docs/src/conf.py index db2cdc3633..4a5d866c2f 100644 --- a/docs/src/conf.py +++ b/docs/src/conf.py @@ -246,6 +246,8 @@ def _dotv(version): extlinks = { "issue": ("https://github.com/SciTools/iris/issues/%s", "Issue #"), "pull": ("https://github.com/SciTools/iris/pull/%s", "PR #"), + "issue_only": ("https://github.com/SciTools/iris/issues/%s", "#"), + "author": ("https://github.com/%s", "@"), } # -- Doctest ("make doctest")-------------------------------------------------- @@ -302,6 +304,15 @@ def _dotv(version): html_static_path = ["_static"] html_style = "theme_override.css" +# this allows for using datatables: https://datatables.net/ +html_css_files = [ + "https://cdn.datatables.net/1.10.23/css/jquery.dataTables.min.css", +] + +html_js_files = [ + "https://cdn.datatables.net/1.10.23/js/jquery.dataTables.min.js", +] + # url link checker. Some links work but report as broken, lets ignore them. # See https://www.sphinx-doc.org/en/1.2/config.html#options-for-the-linkcheck-builder linkcheck_ignore = [ diff --git a/docs/src/index.rst b/docs/src/index.rst index e6a787a220..d6270d60cc 100644 --- a/docs/src/index.rst +++ b/docs/src/index.rst @@ -165,3 +165,4 @@ For **Iris 2.4** and earlier documentation please see the generated/api/iris techpapers/index copyright + votable_issues diff --git a/docs/src/votable_issues.rst b/docs/src/votable_issues.rst new file mode 100644 index 0000000000..a824dfc002 --- /dev/null +++ b/docs/src/votable_issues.rst @@ -0,0 +1,55 @@ +.. include:: common_links.inc + +.. _votable_issues: + +Votable Issues +============== + +You can help us to prioritise development of new features by leaving a 👍 +reaction on the header (not subsequent comments) of any issue that has a +label of ``Feature: Votable``. + +Below is a list of all current enhancement issues from our github +project ordered by the amount of 👍. + +Please note that there is more development activity than what is on the below +table, this is focusing only on the votable issues. + +.. note:: The data in this table is updated daily and is sourced from + `votable-issues.json`_. + For the latest data please see the `votable issues on GitHub`_. + Note that the list on Github does not show the number of votes 👍 + only the total number of comments for the whole issue. + +.. todo:: update the latest.rst to show the PR number when known. + +.. _votable-issues.json: https://github.com/scitools/votable_issues/blob/main/votable-issues.json + +.. raw:: html + + + + + + + + + + +
👍IssueAuthorTitle
+ + + + + diff --git a/docs/src/whatsnew/dev.rst b/docs/src/whatsnew/dev.rst index b9d5989bfc..1772c35005 100644 --- a/docs/src/whatsnew/dev.rst +++ b/docs/src/whatsnew/dev.rst @@ -72,7 +72,8 @@ This document explains the changes made to Iris for this release 📚 Documentation ================ -#. N/A +#. `@tkknight`_ added a page to show the issues that can be voted on. See + :ref:`votable_issues`. (:issue:`3307`, :pull:`????`) 💼 Internal From 68c44f80ecc31610a43704bbf0e5f01aee338d60 Mon Sep 17 00:00:00 2001 From: Tremain Knight <2108488+tkknight@users.noreply.github.com> Date: Wed, 2 Mar 2022 17:15:38 +0000 Subject: [PATCH 34/39] tidy --- .github/workflows/refresh-votable-issues.yml | 44 -------------------- 1 file changed, 44 deletions(-) delete mode 100644 .github/workflows/refresh-votable-issues.yml diff --git a/.github/workflows/refresh-votable-issues.yml b/.github/workflows/refresh-votable-issues.yml deleted file mode 100644 index 1c08bd4a2d..0000000000 --- a/.github/workflows/refresh-votable-issues.yml +++ /dev/null @@ -1,44 +0,0 @@ -# Uses Github API to get a list of issues that have votes on and then -# update a gist with the results in json - -name: Refresh Votable Issues -on: - workflow_dispatch: - branches: [ votable_issues ] -jobs: - votable_main: - runs-on: ubuntu-latest - steps: - # Checks-out your repositories under $GITHUB_WORKSPACE, so your job can access it - - name: checkout iris - uses: actions/checkout@v2 - with: - repository: tkknight/iris - ref: votable_issues - path: iris - - - name: checkout the repo with the json to update - uses: actions/checkout@v2 - with: - # TODO: use the proper repo! - repository: tkknight/votable_issues - ref: main - path: votable_issues - - # setup python - - name: Set up Python 3.9 - uses: actions/setup-python@v2 - with: - python-version: 3.9 - - name: Install dependencies - run: | - python -m pip install --upgrade pip - pip install PyGithub - # run the python scripts passing in the github token - - name: Run the python - run: | - export GH_TOKEN=${{ secrets.GITHUB_TOKEN }} - python $GITHUB_WORKSPACE/iris/docs/src/query_gh_votable_issues.py - ls -al $GITHUB_WORKSPACE - # update the reop with the new file, try https://github.com/marketplace/actions/update-files-on-github - # JP suggests: https://github.com/MetOffice/ssstack/blob/main/.github/workflows/publish-docs.yml From faf280f7fd38d75e961b7342e2f4f0a796afc2aa Mon Sep 17 00:00:00 2001 From: Tremain Knight <2108488+tkknight@users.noreply.github.com> Date: Thu, 3 Mar 2022 10:38:20 +0000 Subject: [PATCH 35/39] updated whatsnew --- docs/src/votable_issues.rst | 2 -- docs/src/whatsnew/dev.rst | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/src/votable_issues.rst b/docs/src/votable_issues.rst index a824dfc002..c39081cc5e 100644 --- a/docs/src/votable_issues.rst +++ b/docs/src/votable_issues.rst @@ -21,8 +21,6 @@ table, this is focusing only on the votable issues. Note that the list on Github does not show the number of votes 👍 only the total number of comments for the whole issue. -.. todo:: update the latest.rst to show the PR number when known. - .. _votable-issues.json: https://github.com/scitools/votable_issues/blob/main/votable-issues.json .. raw:: html diff --git a/docs/src/whatsnew/dev.rst b/docs/src/whatsnew/dev.rst index 1772c35005..1830a668c2 100644 --- a/docs/src/whatsnew/dev.rst +++ b/docs/src/whatsnew/dev.rst @@ -73,7 +73,7 @@ This document explains the changes made to Iris for this release ================ #. `@tkknight`_ added a page to show the issues that can be voted on. See - :ref:`votable_issues`. (:issue:`3307`, :pull:`????`) + :ref:`votable_issues`. (:issue:`3307`, :pull:`4617`) 💼 Internal From 39a69192284eea4b3d999fe3dffc204dd914b821 Mon Sep 17 00:00:00 2001 From: Tremain Knight <2108488+tkknight@users.noreply.github.com> Date: Thu, 3 Mar 2022 15:05:04 +0000 Subject: [PATCH 36/39] removed defunct ext links --- docs/src/conf.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/src/conf.py b/docs/src/conf.py index 4a5d866c2f..9c379ea730 100644 --- a/docs/src/conf.py +++ b/docs/src/conf.py @@ -246,8 +246,6 @@ def _dotv(version): extlinks = { "issue": ("https://github.com/SciTools/iris/issues/%s", "Issue #"), "pull": ("https://github.com/SciTools/iris/pull/%s", "PR #"), - "issue_only": ("https://github.com/SciTools/iris/issues/%s", "#"), - "author": ("https://github.com/%s", "@"), } # -- Doctest ("make doctest")-------------------------------------------------- From 4b52886bb5863ba463fe0cacdfb96373330512c1 Mon Sep 17 00:00:00 2001 From: tkknight <2108488+tkknight@users.noreply.github.com> Date: Sun, 6 Mar 2022 18:58:40 +0000 Subject: [PATCH 37/39] Update docs/src/votable_issues.rst Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com> --- docs/src/votable_issues.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/votable_issues.rst b/docs/src/votable_issues.rst index c39081cc5e..77bd156848 100644 --- a/docs/src/votable_issues.rst +++ b/docs/src/votable_issues.rst @@ -9,7 +9,7 @@ You can help us to prioritise development of new features by leaving a 👍 reaction on the header (not subsequent comments) of any issue that has a label of ``Feature: Votable``. -Below is a list of all current enhancement issues from our github +Below is a list of all current votable enhancement issues from our github project ordered by the amount of 👍. Please note that there is more development activity than what is on the below From c266fb03bd67c817cf5fef125e528483985fd621 Mon Sep 17 00:00:00 2001 From: Tremain Knight <2108488+tkknight@users.noreply.github.com> Date: Sun, 6 Mar 2022 19:16:43 +0000 Subject: [PATCH 38/39] added suggestion to subscribe to voted issues. --- docs/src/votable_issues.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/src/votable_issues.rst b/docs/src/votable_issues.rst index 77bd156848..a383bd3ba7 100644 --- a/docs/src/votable_issues.rst +++ b/docs/src/votable_issues.rst @@ -9,6 +9,10 @@ You can help us to prioritise development of new features by leaving a 👍 reaction on the header (not subsequent comments) of any issue that has a label of ``Feature: Votable``. +.. tip:: We suggest you subscribe to the issue so you will be updated. + When viewing the issue there is a **Notifications** + section where you can select to subscribe. + Below is a list of all current votable enhancement issues from our github project ordered by the amount of 👍. From d3bd63f0d7135927913b1bfeb2b145c31f32faaa Mon Sep 17 00:00:00 2001 From: Tremain Knight <2108488+tkknight@users.noreply.github.com> Date: Wed, 9 Mar 2022 16:05:36 +0000 Subject: [PATCH 39/39] Renamed votable to voted. Layout tweaks to the voted issues page. --- docs/src/common_links.inc | 2 +- docs/src/index.rst | 2 +- .../{votable_issues.rst => voted_issues.rst} | 38 +++++++++---------- docs/src/whatsnew/dev.rst | 4 +- 4 files changed, 22 insertions(+), 24 deletions(-) rename docs/src/{votable_issues.rst => voted_issues.rst} (61%) diff --git a/docs/src/common_links.inc b/docs/src/common_links.inc index f8f8e76384..ce7f498d80 100644 --- a/docs/src/common_links.inc +++ b/docs/src/common_links.inc @@ -38,7 +38,7 @@ .. _using git: https://docs.github.com/en/github/using-git .. _requirements/ci/: https://github.com/SciTools/iris/tree/main/requirements/ci .. _CF-UGRID: https://ugrid-conventions.github.io/ugrid-conventions/ -.. _votable issues on GitHub: https://github.com/SciTools/iris/issues?q=is%3Aopen+is%3Aissue+label%3A%22Feature%3A+Votable%22+sort%3Areactions-%2B1-desc +.. _issues on GitHub: https://github.com/SciTools/iris/issues?q=is%3Aopen+is%3Aissue+sort%3Areactions-%2B1-desc .. comment diff --git a/docs/src/index.rst b/docs/src/index.rst index d6270d60cc..d247b93411 100644 --- a/docs/src/index.rst +++ b/docs/src/index.rst @@ -165,4 +165,4 @@ For **Iris 2.4** and earlier documentation please see the generated/api/iris techpapers/index copyright - votable_issues + voted_issues diff --git a/docs/src/votable_issues.rst b/docs/src/voted_issues.rst similarity index 61% rename from docs/src/votable_issues.rst rename to docs/src/voted_issues.rst index a383bd3ba7..edc1c860a2 100644 --- a/docs/src/votable_issues.rst +++ b/docs/src/voted_issues.rst @@ -1,31 +1,22 @@ .. include:: common_links.inc -.. _votable_issues: +.. _voted_issues: -Votable Issues -============== +Voted Issues +============ You can help us to prioritise development of new features by leaving a 👍 -reaction on the header (not subsequent comments) of any issue that has a -label of ``Feature: Votable``. +reaction on the header (not subsequent comments) of any issue. .. tip:: We suggest you subscribe to the issue so you will be updated. When viewing the issue there is a **Notifications** section where you can select to subscribe. -Below is a list of all current votable enhancement issues from our github -project ordered by the amount of 👍. +Below is a sorted table of all issues that have 1 or more 👍 from our github +project. Please note that there is more development activity than what is on +the below table. -Please note that there is more development activity than what is on the below -table, this is focusing only on the votable issues. - -.. note:: The data in this table is updated daily and is sourced from - `votable-issues.json`_. - For the latest data please see the `votable issues on GitHub`_. - Note that the list on Github does not show the number of votes 👍 - only the total number of comments for the whole issue. - -.. _votable-issues.json: https://github.com/scitools/votable_issues/blob/main/votable-issues.json +.. _voted-issues.json: https://github.com/scitools/voted_issues/blob/main/voted-issues.json .. raw:: html @@ -47,11 +38,18 @@ table, this is focusing only on the votable issues. +

+.. note:: The data in this table is updated daily and is sourced from + `voted-issues.json`_. + For the latest data please see the `issues on GitHub`_. + Note that the list on Github does not show the number of votes 👍 + only the total number of comments for the whole issue. \ No newline at end of file diff --git a/docs/src/whatsnew/dev.rst b/docs/src/whatsnew/dev.rst index 1830a668c2..6987d4219c 100644 --- a/docs/src/whatsnew/dev.rst +++ b/docs/src/whatsnew/dev.rst @@ -72,8 +72,8 @@ This document explains the changes made to Iris for this release 📚 Documentation ================ -#. `@tkknight`_ added a page to show the issues that can be voted on. See - :ref:`votable_issues`. (:issue:`3307`, :pull:`4617`) +#. `@tkknight`_ added a page to show the issues that have been voted for. See + :ref:`voted_issues`. (:issue:`3307`, :pull:`4617`) 💼 Internal