-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cubesummary nobt #3982
Cubesummary nobt #3982
Conversation
@pp-mo Is this PR active? I'm guessing not since it's targeting Can it be closed? |
This is just a heads-up + draft to show thinking. I have new code, re-targetted against master, but I am waiting for #3988 before making a PR, as we are still making changes there to the underlying implementation of the CubeSummary class, so requiring re-basing of the CubePrintout code. We agreed yesterday that we will put this |
Replaced by #3998 |
🚀 Pull Request
Description
New code for first eyes. Replaces #3962
Replaced beautifultable with minimalist home-brew solution for printing text entries in columns.
Still WIP
TODO : better code comments + proper testing
FUTURE : This should convert into a follow-on to #3952, when that is done. It will need resolving against changes in that.
IN PROGRESS : I'm working on replacing actual cube summaries with this, and fixing existing tests for that.
Consult Iris pull request check list