Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubesummary nobt #3982

Closed
wants to merge 18 commits into from
Closed

Cubesummary nobt #3982

wants to merge 18 commits into from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Feb 5, 2021

🚀 Pull Request

Description

New code for first eyes. Replaces #3962

Replaced beautifultable with minimalist home-brew solution for printing text entries in columns.

Still WIP

TODO : better code comments + proper testing
FUTURE : This should convert into a follow-on to #3952, when that is done. It will need resolving against changes in that.
IN PROGRESS : I'm working on replacing actual cube summaries with this, and fixing existing tests for that.


Consult Iris pull request check list

This was referenced Feb 5, 2021
@bjlittle
Copy link
Member

bjlittle commented Feb 9, 2021

@pp-mo Is this PR active? I'm guessing not since it's targeting v3.0.x...

Can it be closed?

@pp-mo
Copy link
Member Author

pp-mo commented Feb 10, 2021

@bjlittle Is this PR active? ... Can it be closed?

This is just a heads-up + draft to show thinking.
It was against v3.0.x as we started there in anticipation of the merge back to master.

I have new code, re-targetted against master, but I am waiting for #3988 before making a PR, as we are still making changes there to the underlying implementation of the CubeSummary class, so requiring re-basing of the CubePrintout code.
When #3988 is done, I will close this and replace it.

We agreed yesterday that we will put this CubePrintout code onto master, but keep it private (or maybe in iris.experimental).
Meanwhile, the switch to finally replace the existing Cube.summary() implementation with this will be done initially on the "mesh-data-model" feature branch instead -- just so that we can defer the additional work to fix any awkward test knockons, like its breaking Cube._repr_html_().

@pp-mo pp-mo mentioned this pull request Feb 10, 2021
@pp-mo
Copy link
Member Author

pp-mo commented Feb 10, 2021

Replaced by #3998

@pp-mo pp-mo closed this Feb 10, 2021
@pp-mo pp-mo deleted the cubesummary_nobt branch March 18, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants