Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve iris-grib test failures #3447

Closed
bjlittle opened this issue Oct 4, 2019 · 6 comments
Closed

Resolve iris-grib test failures #3447

bjlittle opened this issue Oct 4, 2019 · 6 comments

Comments

@bjlittle
Copy link
Member

bjlittle commented Oct 4, 2019

See #3446, in particular this comment.

Results in the following errors=10, failures=5 for iris-grib tests, see this associated travis-ci log.

@pp-mo
Copy link
Member

pp-mo commented Oct 4, 2019

A couple of related issues that this ought to close :

@bjlittle
Copy link
Member Author

bjlittle commented Oct 4, 2019

This is also related:

@lbdreyer
Copy link
Member

FYI:
When getting iris_grib (and python-eccodes) to correctly install in the travis job, you can use the installation in the iris-grib repo as a reference. But note that python-eccodes is now available from conda-forge, so we should install it from there rather than a pip install as is done in iris-grib

@bjlittle
Copy link
Member Author

When installing from conda-forge note the approach used in travis-ci, which ensures that installing iris-grib doesn't install iris as it's dependency - which could replace the development version of iris being tested.

@stephenworsley
Copy link
Contributor

I have begun to adress these in #3469.

@pp-mo pp-mo removed their assignment Oct 17, 2019
@lbdreyer
Copy link
Member

#3469 has addressed most of the test failures, skipping the three that cannot be fixed in iris.

I have raised an new PR to target the work of moving these tests to iris-grib where the necessary fixes can be applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants