Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netcdftime as a dependency #3014

Closed
wants to merge 2 commits into from

Conversation

lbdreyer
Copy link
Member

@lbdreyer lbdreyer commented May 10, 2018

As netcdf4 v1.4.0, netcdftime has been removed and so needs to be added as a separate dependency

The conda-forge recipe will also need updating

The conda build of cf_units v1.2 will also need updating (The latestcf_units has removed the dependency on netcdftime)

@lbdreyer
Copy link
Member Author

@bjlittle
Copy link
Member

👍 Thanks @lbdreyer, but we're going to resolve this with #3016

@bjlittle bjlittle closed this May 14, 2018
@lbdreyer
Copy link
Member Author

I've updated the iris 2.0.0 recipe so that people who are getting iris from conda-forge, pick up a version of netcdf4 that works:
conda-forge/iris-feedstock#28

I've had a couple of people asking about this.

@pp-mo pp-mo reopened this May 16, 2018
@pp-mo
Copy link
Member

pp-mo commented May 16, 2018

@bjlittle we're going to resolve this with #3016

I think this is now taking too long, and we have a backlog of PRs that aren't getting merged.
@pelson @bjlittle can we reconsider this PR, just to unblock Travis testing on Iris ?

@pp-mo pp-mo mentioned this pull request May 16, 2018
@pp-mo
Copy link
Member

pp-mo commented May 16, 2018

can we reconsider this PR

It seems to need a rebase. I might try that myself ...
How about : #3017 replaces ???

@pelson
Copy link
Member

pelson commented May 16, 2018

How about : #3017 replaces ???

OK.

@pelson pelson closed this May 16, 2018
@pelson
Copy link
Member

pelson commented May 16, 2018

I think this is now taking too long

I agree. Let's get our tests passing before we try moving forwards.

@lbdreyer lbdreyer deleted the netcdftime_dep branch September 3, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants